From: Andrey Pronin <apronin@chromium.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
groeck@chromium.org, smbarber@chromium.org,
dianders@chromium.org
Subject: Re: [PATCH 2/2] tpm: support driver-specific sysfs attrs in tpm_tis_core
Date: Mon, 18 Jul 2016 12:17:31 -0700 [thread overview]
Message-ID: <20160718191731.GA1706@apronin> (raw)
In-Reply-To: <20160718191141.GO31463@intel.com>
On Mon, Jul 18, 2016 at 10:11:41PM +0300, Jarkko Sakkinen wrote:
> On Thu, Jul 14, 2016 at 06:51:36PM -0700, Andrey Pronin wrote:
> > Add attr_group to phy_ops that a driver relying on tpm_tis_core_init
> > can set to have its specific attributes registered in sysfs.
> >
> > Signed-off-by: Andrey Pronin <apronin@chromium.org>
> > ---
> > drivers/char/tpm/tpm-sysfs.c | 1 -
> > drivers/char/tpm/tpm.h | 8 +++++++-
> > drivers/char/tpm/tpm_tis_core.c | 3 +++
> > drivers/char/tpm/tpm_tis_core.h | 1 +
> > 4 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c
> > index 95ce90d..22c9874 100644
> > --- a/drivers/char/tpm/tpm-sysfs.c
> > +++ b/drivers/char/tpm/tpm-sysfs.c
> > @@ -304,7 +304,6 @@ void tpm_sysfs_add_device(struct tpm_chip *chip)
> > * is called before ops is null'd and the sysfs core synchronizes this
> > * removal so that no callbacks are running or can run again
> > */
> > - WARN_ON(chip->groups_cnt != 0);
>
> You should explain this in a commit message if you want to remove it.
>
> In general, this make user space API vendor specific, which is
> unacceptable.
>
> /Jarkko
>
I will drop the vendor-specific part of the patchset and just submit
tpm2-specific sysfs attributes in the next rev. WARN_ON will not be
removed.
next prev parent reply other threads:[~2016-07-18 19:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 1:51 [PATCH 0/2] tpm: driver- and tpm2-specific sysfs attributes Andrey Pronin
2016-07-15 1:51 ` [PATCH 1/2] tpm: add sysfs attributes for tpm2 Andrey Pronin
2016-07-15 3:21 ` Jason Gunthorpe
2016-07-15 3:32 ` Andrey Pronin
2016-07-15 3:34 ` Jason Gunthorpe
2016-07-15 16:56 ` Andrey Pronin
2016-07-15 17:09 ` Jason Gunthorpe
2016-07-18 19:16 ` Jarkko Sakkinen
2016-07-15 1:51 ` [PATCH 2/2] tpm: support driver-specific sysfs attrs in tpm_tis_core Andrey Pronin
2016-07-15 3:23 ` Jason Gunthorpe
2016-07-15 3:35 ` Andrey Pronin
2016-07-18 19:20 ` Jarkko Sakkinen
2016-07-18 19:11 ` Jarkko Sakkinen
2016-07-18 19:17 ` Andrey Pronin [this message]
2016-07-20 2:51 ` [PATCH v2] tpm: add sysfs attributes for tpm2 Andrey Pronin
2016-07-20 17:05 ` Jason Gunthorpe
2016-07-20 17:41 ` Andrey Pronin
2016-07-28 4:06 ` [PATCH v3] " Andrey Pronin
2016-08-09 10:25 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718191731.GA1706@apronin \
--to=apronin@chromium.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=smbarber@chromium.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).