From: Jiri Olsa <jolsa@redhat.com>
To: Songshan Gong <gongss@linux.vnet.ibm.com>
Cc: acme@kernel.org, jolsa@kernel.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC V1]s390/perf: fix 'start' address of module's map
Date: Fri, 15 Jul 2016 10:27:43 +0200 [thread overview]
Message-ID: <20160715082743.GA29020@krava> (raw)
In-Reply-To: <6c0b22d7-d912-fd96-c6e6-d14123ca89a3@linux.vnet.ibm.com>
On Fri, Jul 15, 2016 at 03:45:24PM +0800, Songshan Gong wrote:
>
>
> 在 7/13/2016 5:07 PM, Jiri Olsa 写道:
> > On Wed, Jul 13, 2016 at 02:39:13PM +0800, Songshan Gong wrote:
> > >
> > >
> > > 在 7/11/2016 8:01 PM, Jiri Olsa 写道:
> > > > On Mon, Jul 11, 2016 at 07:06:14PM +0800, Songshan Gong wrote:
> > > >
> > > > SNIP
> > > >
> > > > > >
> > > > > > we have following functions in tools/lib/api/fs to read
> > > > > > single number from file, which I assume you do above:
> > > > > >
> > > > > > int sysfs__read_int(const char *entry, int *value);
> > > > > > int sysfs__read_ull(const char *entry, unsigned long long *value);
> > > > > >
> > > > > > please check if you could use some of them,
> > > > > > we could add some more generic one if needed
> > > > >
> > > > > It seems infeasible.
> > > > > Each value in /sys/module/[module name]/sections/.text is a string like
> > > > > "0x000003ff8130078\n".
> > > > > But the core function 'strtoull(line, NULL, 10)' in sysfs__read_ull is based
> > > > > on decimal.
> > > > >
> > > > > Maybe you can introduce a new argument indicating the value is based on hex
> > > > > or decimal, or binary?
> > > >
> > > > yea we could specify it directly and add something like:
> > > >
> > > > int filename__read_ull(const char *filename, unsigned long long *value, int base)
> > > >
> > > > plus some other higher layer helpers..
> > > >
> > > > but I wonder if we could use the base 0 (like in the attached patch),
> > > > the man page says it should be able to detect the base
> > > >
> > > > we'd need to check all the current usage to make sure nothing gets broken
> > > >
> > > > jirka
> > > >
> > > >
> > >
> > > Since your patch havn't pushed to devel branch, my next version patch will
> > > still use the origin method to parse value from /sys/.
> >
> > I'll make/send the change during this week,
> >
>
> Oh, could you remind me after you've done?
> Thanks a lot.
>
I posted it this morning, you're CC-ed
jirka
next prev parent reply other threads:[~2016-07-15 8:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 1:49 [PATCH] [RFC V1]s390/perf: fix 'start' address of module's map Song Shan Gong
2016-07-08 2:17 ` Songshan Gong
2016-07-08 15:20 ` Jiri Olsa
2016-07-08 15:18 ` Jiri Olsa
2016-07-11 8:11 ` Songshan Gong
2016-07-13 3:32 ` Songshan Gong
2016-07-08 15:20 ` Jiri Olsa
2016-07-08 15:21 ` Jiri Olsa
2016-07-08 15:21 ` Jiri Olsa
2016-07-11 11:06 ` Songshan Gong
2016-07-11 12:01 ` Jiri Olsa
2016-07-13 6:39 ` Songshan Gong
2016-07-13 9:07 ` Jiri Olsa
2016-07-15 7:45 ` Songshan Gong
2016-07-15 8:27 ` Jiri Olsa [this message]
2016-07-15 13:23 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715082743.GA29020@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=gongss@linux.vnet.ibm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).