From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Jiri Pirko <jiri@mellanox.com>, Jiri Olsa <jolsa@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 1/3] perf script python: Fix string vs byte array resolving
Date: Fri, 15 Jul 2016 13:37:31 -0300 [thread overview]
Message-ID: <20160715163731.GA18928@kernel.org> (raw)
In-Reply-To: <20160715161310.GA831@krava>
Em Fri, Jul 15, 2016 at 06:13:10PM +0200, Jiri Olsa escreveu:
> On Fri, Jul 15, 2016 at 12:02:31PM -0400, Steven Rostedt wrote:
>
> SNIP
>
> > > for "AA\1\0" this returns "1" although that should return "0".
> > >
> > > orig len 4
> > > decremented len 3
> > > for:
> > > 0 1
> > >
> > > index 2 would not be inspected. Or am I missing something?
> > >
> > > I think that the for check should be "i < len"
> >
> > Yes it should be. I think we got the two solutions mixed up.
> >
> > With the above len--, it should be i < len, but when we did the check
> > for zero at the end, we needed the i < len - 1
>
> ugh right.. should be 'i < len' check in the for loop,
>
> there's also the patch 2/3 that needs to be changed
>
> Arnaldo,
> please let me know if you need me to resend this.
So I need to drop those, even with Rostedt's acked-by? Ok, please
resend, hopefully this time with a Tested-by from the reporter?
- Arnaldo
next prev parent reply other threads:[~2016-07-15 16:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 7:29 [PATCHv2 0/3] perf python: Add support to access tracepoint fields Jiri Olsa
2016-07-15 7:29 ` [PATCH 1/3] perf script python: Fix string vs byte array resolving Jiri Olsa
2016-07-15 7:32 ` Jiri Olsa
2016-07-15 15:30 ` Steven Rostedt
2016-07-15 15:51 ` Jiri Pirko
2016-07-15 16:02 ` Steven Rostedt
2016-07-15 16:13 ` Jiri Olsa
2016-07-15 16:37 ` Arnaldo Carvalho de Melo [this message]
2016-07-15 16:38 ` Arnaldo Carvalho de Melo
2016-07-15 17:16 ` Steven Rostedt
2016-07-15 17:18 ` Steven Rostedt
2016-07-16 15:58 ` Jiri Olsa
2016-07-15 7:29 ` [PATCH 2/3] perf tools: Make is_printable_array global Jiri Olsa
2016-07-15 15:31 ` Steven Rostedt
2016-07-15 7:29 ` [PATCH 3/3] tools lib api fs: Use base 0 in filename__read_ull Jiri Olsa
2016-07-16 20:45 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-07-16 16:11 [PATCHv3 0/3] perf python: Add support to access tracepoint fields Jiri Olsa
2016-07-16 16:11 ` [PATCH 1/3] perf script python: Fix string vs byte array resolving Jiri Olsa
2016-07-18 11:44 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715163731.GA18928@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jiri@mellanox.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).