From: Jiri Olsa <jolsa@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Pirko <jiri@mellanox.com>,
lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 1/3] perf script python: Fix string vs byte array resolving
Date: Sat, 16 Jul 2016 17:58:08 +0200 [thread overview]
Message-ID: <20160716155808.GA16531@krava> (raw)
In-Reply-To: <20160715131840.3a48a0ed@gandalf.local.home>
On Fri, Jul 15, 2016 at 01:18:40PM -0400, Steven Rostedt wrote:
> On Fri, 15 Jul 2016 09:29:55 +0200
> Jiri Olsa <jolsa@kernel.org> wrote:
>
> > + if (field->flags & FIELD_IS_STRING &&
> > + is_printable_array(data + offset, len)) {
> > + obj = PyString_FromString((char *) data + offset);
>
> Hmm. As I stated, It is possible that strings can be non nul
> terminated. But I'm looking here and thinking we need to make sure that
> it is nul terminated.
>
> Can PyString_FromString() handle a non nul terminated string?
couldn't find in the doc.. but I think it's necessary,
there's no other way it could tell the end ;-)
I'll make the is_printable_array in case the final 0 is missing
thanks,
jirka
next prev parent reply other threads:[~2016-07-16 15:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 7:29 [PATCHv2 0/3] perf python: Add support to access tracepoint fields Jiri Olsa
2016-07-15 7:29 ` [PATCH 1/3] perf script python: Fix string vs byte array resolving Jiri Olsa
2016-07-15 7:32 ` Jiri Olsa
2016-07-15 15:30 ` Steven Rostedt
2016-07-15 15:51 ` Jiri Pirko
2016-07-15 16:02 ` Steven Rostedt
2016-07-15 16:13 ` Jiri Olsa
2016-07-15 16:37 ` Arnaldo Carvalho de Melo
2016-07-15 16:38 ` Arnaldo Carvalho de Melo
2016-07-15 17:16 ` Steven Rostedt
2016-07-15 17:18 ` Steven Rostedt
2016-07-16 15:58 ` Jiri Olsa [this message]
2016-07-15 7:29 ` [PATCH 2/3] perf tools: Make is_printable_array global Jiri Olsa
2016-07-15 15:31 ` Steven Rostedt
2016-07-15 7:29 ` [PATCH 3/3] tools lib api fs: Use base 0 in filename__read_ull Jiri Olsa
2016-07-16 20:45 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-07-16 16:11 [PATCHv3 0/3] perf python: Add support to access tracepoint fields Jiri Olsa
2016-07-16 16:11 ` [PATCH 1/3] perf script python: Fix string vs byte array resolving Jiri Olsa
2016-07-18 11:44 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160716155808.GA16531@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jiri@mellanox.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).