* [patch] tools/vm/slabinfo: fix an unintentional printf
@ 2016-07-15 21:12 Dan Carpenter
2016-07-16 3:34 ` Sergey Senozhatsky
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-07-15 21:12 UTC (permalink / raw)
To: Andrew Morton, Christoph Lameter
Cc: Sergey Senozhatsky, Colin Ian King, Laura Abbott, linux-kernel,
kernel-janitors
The curly braces are missing here so we print stuff unintentionally.
Fixes: 9da4714a2d4f ('slub: slabinfo update for cmpxchg handling')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
index 7cf6e17..b9d34b3 100644
--- a/tools/vm/slabinfo.c
+++ b/tools/vm/slabinfo.c
@@ -510,10 +510,11 @@ static void slab_stats(struct slabinfo *s)
s->alloc_node_mismatch, (s->alloc_node_mismatch * 100) / total);
}
- if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail)
+ if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail) {
printf("\nCmpxchg_double Looping\n------------------------\n");
printf("Locked Cmpxchg Double redos %lu\nUnlocked Cmpxchg Double redos %lu\n",
s->cmpxchg_double_fail, s->cmpxchg_double_cpu_fail);
+ }
}
static void report(struct slabinfo *s)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] tools/vm/slabinfo: fix an unintentional printf
2016-07-15 21:12 [patch] tools/vm/slabinfo: fix an unintentional printf Dan Carpenter
@ 2016-07-16 3:34 ` Sergey Senozhatsky
0 siblings, 0 replies; 2+ messages in thread
From: Sergey Senozhatsky @ 2016-07-16 3:34 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andrew Morton, Christoph Lameter, Sergey Senozhatsky,
Colin Ian King, Laura Abbott, linux-kernel, kernel-janitors
On (07/16/16 00:12), Dan Carpenter wrote:
> The curly braces are missing here so we print stuff unintentionally.
>
> Fixes: 9da4714a2d4f ('slub: slabinfo update for cmpxchg handling')
Hello,
a minor correction:
it's 9da4714a2d44
not 9da4714a2d4f
-ss
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
> index 7cf6e17..b9d34b3 100644
> --- a/tools/vm/slabinfo.c
> +++ b/tools/vm/slabinfo.c
> @@ -510,10 +510,11 @@ static void slab_stats(struct slabinfo *s)
> s->alloc_node_mismatch, (s->alloc_node_mismatch * 100) / total);
> }
>
> - if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail)
> + if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail) {
> printf("\nCmpxchg_double Looping\n------------------------\n");
> printf("Locked Cmpxchg Double redos %lu\nUnlocked Cmpxchg Double redos %lu\n",
> s->cmpxchg_double_fail, s->cmpxchg_double_cpu_fail);
> + }
> }
>
> static void report(struct slabinfo *s)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-16 3:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-15 21:12 [patch] tools/vm/slabinfo: fix an unintentional printf Dan Carpenter
2016-07-16 3:34 ` Sergey Senozhatsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).