* [patch v2] tools/vm/slabinfo: fix an unintentional printf
@ 2016-07-16 12:20 Dan Carpenter
2016-07-18 0:31 ` Christoph Lameter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-07-16 12:20 UTC (permalink / raw)
To: Andrew Morton, Christoph Lameter
Cc: Sergey Senozhatsky, Colin Ian King, Laura Abbott, linux-kernel,
kernel-janitors
The curly braces are missing here so we print stuff unintentionally.
Fixes: 9da4714a2d44 ('slub: slabinfo update for cmpxchg handling')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: Fix typo in git hash
diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
index 7cf6e17..b9d34b3 100644
--- a/tools/vm/slabinfo.c
+++ b/tools/vm/slabinfo.c
@@ -510,10 +510,11 @@ static void slab_stats(struct slabinfo *s)
s->alloc_node_mismatch, (s->alloc_node_mismatch * 100) / total);
}
- if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail)
+ if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail) {
printf("\nCmpxchg_double Looping\n------------------------\n");
printf("Locked Cmpxchg Double redos %lu\nUnlocked Cmpxchg Double redos %lu\n",
s->cmpxchg_double_fail, s->cmpxchg_double_cpu_fail);
+ }
}
static void report(struct slabinfo *s)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch v2] tools/vm/slabinfo: fix an unintentional printf
2016-07-16 12:20 [patch v2] tools/vm/slabinfo: fix an unintentional printf Dan Carpenter
@ 2016-07-18 0:31 ` Christoph Lameter
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Lameter @ 2016-07-18 0:31 UTC (permalink / raw)
To: 20160716033419.GA493
Cc: Andrew Morton, Sergey Senozhatsky, Colin Ian King, Laura Abbott,
linux-kernel, kernel-janitors
Acked-by: Christoph Lameter <cl@linux.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-18 0:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-16 12:20 [patch v2] tools/vm/slabinfo: fix an unintentional printf Dan Carpenter
2016-07-18 0:31 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).