linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@suse.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Ingo Molnar <mingo@kernel.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>, Pavel Machek <pavel@ucw.cz>,
	Linux PM list <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	shuzzle@mailbox.org, Thomas Garnier <thgarnie@google.com>,
	Kees Cook <keescook@chromium.org>
Subject: Re: Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk
Date: Tue, 26 Jul 2016 16:04:42 +0200	[thread overview]
Message-ID: <20160726140442.GA2832@nazgul.tnic> (raw)
In-Reply-To: <16541580.dFLT14ScxF@vostro.rjw.lan>

On Tue, Jul 26, 2016 at 01:32:28PM +0200, Rafael J. Wysocki wrote:
> Hi,
> 
> The following commit:
> 
> commit 13523309495cdbd57a0d344c0d5d574987af007f
> Author: Josh Poimboeuf <jpoimboe@redhat.com>
> Date:   Thu Jan 21 16:49:21 2016 -0600
> 
>     x86/asm/acpi: Create a stack frame in do_suspend_lowlevel()
>     
>     do_suspend_lowlevel() is a callable non-leaf function which doesn't
>     honor CONFIG_FRAME_POINTER, which can result in bad stack traces.
>     
>     Create a stack frame for it when CONFIG_FRAME_POINTER is enabled.
> 
> is reported to cause a resume-from-hibernation regression due to an attempt
> to execute an NX page (we've seen quite a bit of that recently).
> 
> I'm asking the reporter to try 4.7, but if the problem is still there, we'll
> need to revert the above I'm afraid.

So I can't resume properly from disk too, on the Intel laptop this time. Top
commit is from tip/master:

commit 516f48acf59722429acd323b3d283f74f02891fe (refs/remotes/tip/master)
Merge: a4823bbffc96 dd9506954539
Author: Ingo Molnar <mingo@kernel.org>
Date:   Mon Jul 25 08:39:43 2016 +0200

    Merge branch 'linus'


So I thought it might be Josh's patch above and reverted it. No joy.

Then I remembered that I enabled CONFIG_RANDOMIZE_MEMORY for the
microcode loader breakage which we've been debugging. Turned that off
and machine resumes fine again.

It looks like

  0483e1fa6e09 ("x86/mm: Implement ASLR for kernel memory regions")

broke a bunch of things. Off the top of my head, we probably should make
suspend to disk and CONFIG_RANDOMIZE_MEMORY mutually exclusive, like it
was the case with ASLR previously, AFAIR.

Adding more people to CC and leaving in the rest for reference.

> Date: Mon, 25 Jul 2016 21:16:29 +0000
> From: bugzilla-daemon@bugzilla.kernel.org
> To: rjw@rjwysocki.net
> Subject: [Bug 150021] New: kernel panic: "kernel tried to execute
>  NX-protected page" when resuming from hibernate to disk
> Message-ID: <bug-150021-76231@https.bugzilla.kernel.org/>
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=150021
> 
>             Bug ID: 150021
>            Summary: kernel panic: "kernel tried to execute NX-protected
>                     page" when resuming from hibernate to disk
>            Product: Power Management
>            Version: 2.5
>     Kernel Version: 4.6.x
>           Hardware: All
>                 OS: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: Hibernation/Suspend
>           Assignee: rjw@rjwysocki.net
>           Reporter: shuzzle@mailbox.org
>         Regression: No
> 
> Created attachment 226381
>   --> https://bugzilla.kernel.org/attachment.cgi?id=226381&action=edit
> last working .config
> 
> Overview: 
> 
> When commit 13523309495cdbd57a0d344c0d5d574987af007f is applied to my kernel
> sources my kernel panics when trying to resume from hibernate to disk.
> 
> 
> Steps to Reproduce: 
> 
> 1. have a working hibernate/resume setup
> 2. compile 4.6.x kernel
> 3. boot and hibernate to disk
> 4. test various kernels using "git bisect".
> 
> 
> Actual Results: kernel panics when trying to resume from hibernate to disk.
> 
> Expected Results: Resume from hibernate to disk like kernels without commit
> 13523309495cdbd57a0d344c0d5d574987af007f did.
> 
> 
> I attached my working .config of my 4.5.7 kernel.
> 
> Any help will be appreciated. Thanks!
> 
> -- 
> You are receiving this mail because:
> You are the assignee for the bug.


-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

  reply	other threads:[~2016-07-26 14:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26 11:32 Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk Rafael J. Wysocki
2016-07-26 14:04 ` Borislav Petkov [this message]
2016-07-26 20:24   ` Rafael J. Wysocki
2016-07-26 20:33     ` Kees Cook
2016-07-26 20:53       ` Rafael J. Wysocki
2016-07-26 20:59         ` Kees Cook
2016-07-26 21:17           ` Thomas Garnier
2016-07-27  5:39             ` Borislav Petkov
2016-07-26 14:39 ` Josh Poimboeuf
2016-07-26 20:15   ` Rafael J. Wysocki
2016-07-26 20:31     ` Kees Cook
2016-07-26 20:42       ` Rafael J. Wysocki
2016-07-26 21:53     ` Josh Poimboeuf
2016-07-26 22:42       ` Rafael J. Wysocki
2016-07-26 23:08         ` Rafael J. Wysocki
2016-07-27 17:59           ` Josh Poimboeuf
2016-07-27 22:12             ` Rafael J. Wysocki
2016-07-27 22:17               ` Josh Poimboeuf
2016-07-27 23:20                 ` Rafael J. Wysocki
2016-07-27 23:29                   ` Rafael J. Wysocki
2016-07-28 15:17                     ` [PATCH] x86/asm/power: Fix hibernation return address corruption Josh Poimboeuf
2016-07-28 15:32                       ` Josh Poimboeuf
2016-07-28 21:36                       ` Rafael J. Wysocki
2016-07-29  7:16                         ` Ingo Molnar
2016-07-27 22:20               ` Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160726140442.GA2832@nazgul.tnic \
    --to=bp@suse.de \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=shuzzle@mailbox.org \
    --cc=tglx@linutronix.de \
    --cc=thgarnie@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).