From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@suse.de>,
Pavel Machek <pavel@ucw.cz>,
Linux PM list <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
shuzzle@mailbox.org
Subject: Re: Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk
Date: Wed, 27 Jul 2016 01:08:21 +0200 [thread overview]
Message-ID: <CAJZ5v0hDuYZXHsK3G0CrQwnKpO0DVa3sNxKpWNHkh8vofJUT8Q@mail.gmail.com> (raw)
In-Reply-To: <4852923.iQFmCCTKQM@vostro.rjw.lan>
On Wed, Jul 27, 2016 at 12:42 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Tuesday, July 26, 2016 04:53:19 PM Josh Poimboeuf wrote:
>> On Tue, Jul 26, 2016 at 10:15:39PM +0200, Rafael J. Wysocki wrote:
>> > On Tuesday, July 26, 2016 09:39:05 AM Josh Poimboeuf wrote:
>> > > On Tue, Jul 26, 2016 at 01:32:28PM +0200, Rafael J. Wysocki wrote:
>> > > > Hi,
>> > > >
>> > > > The following commit:
>> > > >
>> > > > commit 13523309495cdbd57a0d344c0d5d574987af007f
>> > > > Author: Josh Poimboeuf <jpoimboe@redhat.com>
>> > > > Date: Thu Jan 21 16:49:21 2016 -0600
>> > > >
>> > > > x86/asm/acpi: Create a stack frame in do_suspend_lowlevel()
>> > > >
>> > > > do_suspend_lowlevel() is a callable non-leaf function which doesn't
>> > > > honor CONFIG_FRAME_POINTER, which can result in bad stack traces.
>> > > >
>> > > > Create a stack frame for it when CONFIG_FRAME_POINTER is enabled.
>> > > >
>> > > > is reported to cause a resume-from-hibernation regression due to an attempt
>> > > > to execute an NX page (we've seen quite a bit of that recently).
>> > > >
>> > > > I'm asking the reporter to try 4.7, but if the problem is still there, we'll
>> > > > need to revert the above I'm afraid.
>> >
>> > So the bug is still there in 4.7 and it goes away after reverting the above
>> > commit. I guess I'll send a revert then.
>>
>> Hm, the code in wakeup_64.S seems quite magical, but I can't figure out
>> why this change causes a panic. Is it really causing the panic or is it
>> uncovering some other bug?
>
> It doesn't matter really.
>
> It surely interacts with something in a really odd way, but that only means
> that its impact goes far beyond what was expected when it was applied. Its
> changelog is inadequate as a result and so on.
>
>> Maybe we should hold off on reverting until we understand the issue.
>
> Which very well may take forever.
>
> And AFAICS this is a fix for a theoretical issue and it *reliably* triggers a
> very practical kernel panic for this particular reporter. I'd rather live
> with the theoretical issue unfixed to be honest.
Well, actually, the best part is that do_suspend_lowlevel() is not
even called during hibernation or resume from it. It only is called
during suspend-to-RAM.
Question now is how the change made by the commit in question can
affect hibernation which is an unrelated code path. We know for a
fact that it does affect it, but how?
Thanks,
Rafael
next prev parent reply other threads:[~2016-07-26 23:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 11:32 Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk Rafael J. Wysocki
2016-07-26 14:04 ` Borislav Petkov
2016-07-26 20:24 ` Rafael J. Wysocki
2016-07-26 20:33 ` Kees Cook
2016-07-26 20:53 ` Rafael J. Wysocki
2016-07-26 20:59 ` Kees Cook
2016-07-26 21:17 ` Thomas Garnier
2016-07-27 5:39 ` Borislav Petkov
2016-07-26 14:39 ` Josh Poimboeuf
2016-07-26 20:15 ` Rafael J. Wysocki
2016-07-26 20:31 ` Kees Cook
2016-07-26 20:42 ` Rafael J. Wysocki
2016-07-26 21:53 ` Josh Poimboeuf
2016-07-26 22:42 ` Rafael J. Wysocki
2016-07-26 23:08 ` Rafael J. Wysocki [this message]
2016-07-27 17:59 ` Josh Poimboeuf
2016-07-27 22:12 ` Rafael J. Wysocki
2016-07-27 22:17 ` Josh Poimboeuf
2016-07-27 23:20 ` Rafael J. Wysocki
2016-07-27 23:29 ` Rafael J. Wysocki
2016-07-28 15:17 ` [PATCH] x86/asm/power: Fix hibernation return address corruption Josh Poimboeuf
2016-07-28 15:32 ` Josh Poimboeuf
2016-07-28 21:36 ` Rafael J. Wysocki
2016-07-29 7:16 ` Ingo Molnar
2016-07-27 22:20 ` Fwd: [Bug 150021] New: kernel panic: "kernel tried to execute NX-protected page" when resuming from hibernate to disk Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0hDuYZXHsK3G0CrQwnKpO0DVa3sNxKpWNHkh8vofJUT8Q@mail.gmail.com \
--to=rafael@kernel.org \
--cc=bp@suse.de \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=shuzzle@mailbox.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).