linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
	bardliao@realtek.com, oder_chiou@realtek.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org, vinod.koul@intel.com
Subject: Re: [PATCH] ASoC: rt5659: Add mclk controls
Date: Thu, 28 Jul 2016 16:57:32 +0100	[thread overview]
Message-ID: <20160728155732.GG11806@sirena.org.uk> (raw)
In-Reply-To: <1469660568-3511-1-git-send-email-nicoleotsuka@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

On Wed, Jul 27, 2016 at 04:02:48PM -0700, Nicolin Chen wrote:

> The codec driver should control the mclk. So this patch adds this support.

> +	/* Check if MCLK provided */
> +	rt5659->mclk = devm_clk_get(&i2c->dev, "mclk");
> +	if (IS_ERR(rt5659->mclk)) {
> +		if (PTR_ERR(rt5659->mclk) == -EPROBE_DEFER)
> +			return -EPROBE_DEFER;
> +		/* Otherwise mark the mclk pointer to NULL */
> +		rt5659->mclk = NULL;
> +	}

This device seems to be used on x86 systems so we'll need to ensure that
they register clocks for this.  They really should set this up using
quirks keyed off DMI information or similar so it's hidden from other
systems.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-07-28 15:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27 23:02 [PATCH] ASoC: rt5659: Add mclk controls Nicolin Chen
2016-07-28 15:57 ` Mark Brown [this message]
2016-07-28 18:14   ` Nicolin Chen
2016-07-28 18:55     ` Mark Brown
2016-07-28 19:03       ` Nicolin Chen
2016-07-29 16:15       ` Vinod Koul
2016-07-29 16:39         ` Mark Brown
2016-07-29 16:55           ` [alsa-devel] " Vinod Koul
2016-08-10 13:57           ` Pierre-Louis Bossart
2016-08-10 17:06             ` Mark Brown
2016-08-10 17:31               ` Pierre-Louis Bossart
2016-08-10 17:52                 ` Mark Brown
2016-08-10 21:59                   ` Pierre-Louis Bossart
2016-08-11 11:34                     ` Mark Brown
2016-07-28 20:40 ` Lars-Peter Clausen
2016-07-28 20:51   ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160728155732.GG11806@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bardliao@realtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=oder_chiou@realtek.com \
    --cc=robh+dt@kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).