From: Andrew Morton <akpm@linux-foundation.org>
To: zhongjiang <zhongjiang@huawei.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs: wipe off the compiler warn
Date: Fri, 29 Jul 2016 16:02:47 -0700 [thread overview]
Message-ID: <20160729160247.564e27525f04416ef714ddd4@linux-foundation.org> (raw)
In-Reply-To: <1469803600-44293-1-git-send-email-zhongjiang@huawei.com>
On Fri, 29 Jul 2016 22:46:39 +0800 zhongjiang <zhongjiang@huawei.com> wrote:
> From: zhong jiang <zhongjiang@huawei.com>
>
> when compile the kenrel code, I happens to the following warn.
> fs/reiserfs/ibalance.c:1156:2: warning: ___new_insert_key___ may be used
> uninitialized in this function.
> memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
> ^
> The patch just fix it to avoid the warn.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> fs/reiserfs/ibalance.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/reiserfs/ibalance.c b/fs/reiserfs/ibalance.c
> index b751eea..512ce95 100644
> --- a/fs/reiserfs/ibalance.c
> +++ b/fs/reiserfs/ibalance.c
> @@ -818,7 +818,7 @@ int balance_internal(struct tree_balance *tb,
> int order;
> int insert_num, n, k;
> struct buffer_head *S_new;
> - struct item_head new_insert_key;
> + struct item_head uninitialized_var(new_insert_key);
> struct buffer_head *new_insert_ptr = NULL;
> struct item_head *new_insert_key_addr = insert_key;
How do we know this isn't a real bug? It isn't obvious to me that this
warning is a false positive.
next prev parent reply other threads:[~2016-07-29 23:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 14:46 [PATCH] fs: wipe off the compiler warn zhongjiang
2016-07-29 23:02 ` Andrew Morton [this message]
2016-07-30 2:38 ` zhong jiang
-- strict thread matches above, loose matches on Subject: below --
2016-07-29 14:45 zhongjiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729160247.564e27525f04416ef714ddd4@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).