* [PATCH 0/1] drivers: staging: android: Remove checkpatch.pl-TODO
@ 2016-07-30 13:13 Matthias Beyer
2016-07-30 13:13 ` [PATCH 1/1] Remove checkpatch.pl cleanups todo Matthias Beyer
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Beyer @ 2016-07-30 13:13 UTC (permalink / raw)
To: arve, riandrews; +Cc: Matthias Beyer, gregkh, devel, linux-kernel
Hi Arve,
Hi Riley,
I just noticed that the drivers/staging/android driver has only 4
remaining checkpatch.pl warnings, two of them beeing
80-character-per-line warnings (the two lines are 81 characters
exactly).
The other warnings are:
./sw_sync.c:258: WARNING: memory barrier without comment
./uapi/ion.h:23: WARNING: do not add new typedefs
I'm not sure about the first one, though I could provide a patch for
the second one. The change would simply remove
typedef int ion_user_handle_t;
and replace all occurences of `ion_user_handle_t` with `int`.
I'm not sure, though, whether such a patch would be welcome.
Either way, I propose to remove the TODO note on checkpatch cleanup
with the attached patch.
Matthias Beyer (1):
Remove checkpatch.pl cleanups todo
drivers/staging/android/TODO | 1 -
1 file changed, 1 deletion(-)
--
2.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] Remove checkpatch.pl cleanups todo
2016-07-30 13:13 [PATCH 0/1] drivers: staging: android: Remove checkpatch.pl-TODO Matthias Beyer
@ 2016-07-30 13:13 ` Matthias Beyer
2016-08-15 14:53 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Beyer @ 2016-07-30 13:13 UTC (permalink / raw)
To: arve, riandrews; +Cc: Matthias Beyer, gregkh, devel, linux-kernel
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
---
drivers/staging/android/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
index 64d8c87..4ce0ac6 100644
--- a/drivers/staging/android/TODO
+++ b/drivers/staging/android/TODO
@@ -1,5 +1,4 @@
TODO:
- - checkpatch.pl cleanups
- sparse fixes
- rename files to be not so "generic"
- add proper arch dependencies as needed
--
2.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Remove checkpatch.pl cleanups todo
2016-07-30 13:13 ` [PATCH 1/1] Remove checkpatch.pl cleanups todo Matthias Beyer
@ 2016-08-15 14:53 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-08-15 14:53 UTC (permalink / raw)
To: Matthias Beyer; +Cc: arve, riandrews, devel, linux-kernel
On Sat, Jul 30, 2016 at 03:13:38PM +0200, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
I can't take patches without any changelog comments in them :(
Please put the info you put in the 0/1 email in here.
And for a single patch, you never need a 0/1 email.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-15 14:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-30 13:13 [PATCH 0/1] drivers: staging: android: Remove checkpatch.pl-TODO Matthias Beyer
2016-07-30 13:13 ` [PATCH 1/1] Remove checkpatch.pl cleanups todo Matthias Beyer
2016-08-15 14:53 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).