From: Jiri Olsa <jolsa@redhat.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 3/6] perf tools: add infrastructure for PMU specific configuration
Date: Sun, 31 Jul 2016 14:02:19 +0200 [thread overview]
Message-ID: <20160731120219.GA12673@krava> (raw)
In-Reply-To: <1469742143-22245-4-git-send-email-mathieu.poirier@linaro.org>
On Thu, Jul 28, 2016 at 03:42:20PM -0600, Mathieu Poirier wrote:
> This patch adds PMU driver specific configuration to the parser
> infrastructure by preceding any term with the '@' letter. As such
> doing something like:
>
> perf record -e some_event/@cfg1,@cfg2=config/ ...
>
> will see 'cfg1' and 'cfg2=config' being added to the list of evsel config
> terms. Token 'cfg1' and 'cfg2=config' are not processed in user space
> and are meant to be interpreted by the PMU driver.
>
> First the lexer/parser are supplemented with the required definitions to
> recognise the driver specific configuration. From there they are simply
> added to the list of event terms. The bulk of the work is done in
> function "parse_events_add_pmu()" where driver config event terms are
> added to a new list of driver config terms, which in turn spliced with
> the event's new driver configuration list.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2016-07-31 12:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 21:42 [PATCH V3 0/6] perf: Driver specific configuration for PMU Mathieu Poirier
2016-07-28 21:42 ` [PATCH V3 1/6] perf/core: Adding PMU driver specific configuration Mathieu Poirier
2016-08-04 16:58 ` Peter Zijlstra
2016-08-05 15:35 ` Mathieu Poirier
2016-08-05 15:53 ` Peter Zijlstra
2016-08-10 23:07 ` Mathieu Poirier
2016-08-11 3:27 ` Vince Weaver
2016-08-04 16:59 ` Peter Zijlstra
2016-08-05 15:41 ` Mathieu Poirier
2016-08-05 15:54 ` Peter Zijlstra
2016-07-28 21:42 ` [PATCH V3 2/6] perf: Passing struct perf_event to function setup_aux() Mathieu Poirier
2016-08-04 17:19 ` Peter Zijlstra
2016-08-08 10:49 ` Alexander Shishkin
2016-08-08 14:38 ` Mathieu Poirier
2016-07-28 21:42 ` [PATCH V3 3/6] perf tools: add infrastructure for PMU specific configuration Mathieu Poirier
2016-07-31 12:02 ` Jiri Olsa [this message]
2016-07-28 21:42 ` [PATCH V3 4/6] perf tools: pushing driver configuration down to the kernel Mathieu Poirier
2016-07-31 12:03 ` Jiri Olsa
2016-08-03 21:46 ` Mathieu Poirier
2016-07-28 21:42 ` [PATCH V3 5/6] coresight: adding sink parameter to function coresight_build_path() Mathieu Poirier
2016-07-28 21:42 ` [PATCH V3 6/6] coresight: etm-perf: incorporating sink definition from cmd line Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160731120219.GA12673@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).