From: Peter Zijlstra <peterz@infradead.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
jolsa@kernel.org, Ingo Molnar <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific configuration
Date: Fri, 5 Aug 2016 17:54:42 +0200 [thread overview]
Message-ID: <20160805155442.GW6879@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CANLsYkwNwtYHZ+BLt7iuB919zbCUUs2thfkU-bMH-+e5eMxAxg@mail.gmail.com>
On Fri, Aug 05, 2016 at 09:41:15AM -0600, Mathieu Poirier wrote:
> On 4 August 2016 at 10:59, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Thu, Jul 28, 2016 at 03:42:18PM -0600, Mathieu Poirier wrote:
> >> This patch somewhat mimics the work done on address filters to
> >> add the infrastructure needed to pass PMU specific HW
> >> configuration to the driver before a session starts.
> >
> > I'm thinking we want to specify a syntax and validate the string matches
> > the syntax in the generic code.
>
> The syntax is checked in the lexer making sure that nothing other than
> @cfg or @cfg=config is sent to the kernel. From there validation is
> done in the PMU driver that implements the set_drv_configs()
> interface.
>
> I am not sure to get you point here - can I ask you to provide more details?
What keeps random userspace from sending malformed strings in? There's
more userspace than just the perf tool.
The kernel needs to validate structure.
next prev parent reply other threads:[~2016-08-05 15:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 21:42 [PATCH V3 0/6] perf: Driver specific configuration for PMU Mathieu Poirier
2016-07-28 21:42 ` [PATCH V3 1/6] perf/core: Adding PMU driver specific configuration Mathieu Poirier
2016-08-04 16:58 ` Peter Zijlstra
2016-08-05 15:35 ` Mathieu Poirier
2016-08-05 15:53 ` Peter Zijlstra
2016-08-10 23:07 ` Mathieu Poirier
2016-08-11 3:27 ` Vince Weaver
2016-08-04 16:59 ` Peter Zijlstra
2016-08-05 15:41 ` Mathieu Poirier
2016-08-05 15:54 ` Peter Zijlstra [this message]
2016-07-28 21:42 ` [PATCH V3 2/6] perf: Passing struct perf_event to function setup_aux() Mathieu Poirier
2016-08-04 17:19 ` Peter Zijlstra
2016-08-08 10:49 ` Alexander Shishkin
2016-08-08 14:38 ` Mathieu Poirier
2016-07-28 21:42 ` [PATCH V3 3/6] perf tools: add infrastructure for PMU specific configuration Mathieu Poirier
2016-07-31 12:02 ` Jiri Olsa
2016-07-28 21:42 ` [PATCH V3 4/6] perf tools: pushing driver configuration down to the kernel Mathieu Poirier
2016-07-31 12:03 ` Jiri Olsa
2016-08-03 21:46 ` Mathieu Poirier
2016-07-28 21:42 ` [PATCH V3 5/6] coresight: adding sink parameter to function coresight_build_path() Mathieu Poirier
2016-07-28 21:42 ` [PATCH V3 6/6] coresight: etm-perf: incorporating sink definition from cmd line Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805155442.GW6879@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).