* [PATCH 0413/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 11:09 Baole Ni
0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 11:09 UTC (permalink / raw)
To: mchehab, maurochehab, mchehab, mchehab, m.chehab, kyungmin.park,
riverful.kim, bp
Cc: linux-media, linux-kernel, chuansheng.liu, baolex.ni
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/media/i2c/m5mols/m5mols_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/m5mols/m5mols_core.c b/drivers/media/i2c/m5mols/m5mols_core.c
index acb804b..df6499e 100644
--- a/drivers/media/i2c/m5mols/m5mols_core.c
+++ b/drivers/media/i2c/m5mols/m5mols_core.c
@@ -31,7 +31,7 @@
#include "m5mols_reg.h"
int m5mols_debug;
-module_param(m5mols_debug, int, 0644);
+module_param(m5mols_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
#define MODULE_NAME "M5MOLS"
#define M5MOLS_I2C_CHECK_RETRY 500
--
2.9.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-08-02 17:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 11:09 [PATCH 0413/1285] Replace numeric parameter like 0444 with macro Baole Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).