linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0433/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 11:11 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 11:11 UTC (permalink / raw)
  To: mchehab, maurochehab, mchehab, mchehab, m.chehab, hverkuil, a.hajda, bp
  Cc: linux-media, linux-kernel, k.kozlowski, arnd, chuansheng.liu, baolex.ni

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/media/i2c/tvaudio.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/media/i2c/tvaudio.c b/drivers/media/i2c/tvaudio.c
index fece2a4..8c740d8 100644
--- a/drivers/media/i2c/tvaudio.c
+++ b/drivers/media/i2c/tvaudio.c
@@ -46,7 +46,7 @@
 /* insmod args                                                            */
 
 static int debug;	/* insmod parameter */
-module_param(debug, int, 0644);
+module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
 MODULE_DESCRIPTION("device driver for various i2c TV sound decoder / audiomux chips");
 MODULE_AUTHOR("Eric Sandeen, Steve VanDeBogart, Greg Alexander, Gerd Knorr");
@@ -845,9 +845,9 @@ static int tda9874a_dic = -1;		/* device id. code */
 static unsigned int tda9874a_SIF   = UNSET;
 static unsigned int tda9874a_AMSEL = UNSET;
 static unsigned int tda9874a_STD   = UNSET;
-module_param(tda9874a_SIF, int, 0444);
-module_param(tda9874a_AMSEL, int, 0444);
-module_param(tda9874a_STD, int, 0444);
+module_param(tda9874a_SIF, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(tda9874a_AMSEL, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(tda9874a_STD, int, S_IRUSR | S_IRGRP | S_IROTH);
 
 /*
  * initialization table for tda9874 decoder:
@@ -1454,18 +1454,18 @@ static int tea6420  = 1;
 static int pic16c54 = 1;
 static int ta8874z;	/* default 0 - address clash with tda9840 */
 
-module_param(tda8425, int, 0444);
-module_param(tda9840, int, 0444);
-module_param(tda9850, int, 0444);
-module_param(tda9855, int, 0444);
-module_param(tda9873, int, 0444);
-module_param(tda9874a, int, 0444);
-module_param(tda9875, int, 0444);
-module_param(tea6300, int, 0444);
-module_param(tea6320, int, 0444);
-module_param(tea6420, int, 0444);
-module_param(pic16c54, int, 0444);
-module_param(ta8874z, int, 0444);
+module_param(tda8425, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(tda9840, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(tda9850, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(tda9855, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(tda9873, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(tda9874a, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(tda9875, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(tea6300, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(tea6320, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(tea6420, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(pic16c54, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(ta8874z, int, S_IRUSR | S_IRGRP | S_IROTH);
 
 static struct CHIPDESC chiplist[] = {
 	{
-- 
2.9.2

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-02 17:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 11:11 [PATCH 0433/1285] Replace numeric parameter like 0444 with macro Baole Ni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).