From: Matt Fleming <matt@codeblueprint.co.uk>
To: Austin Christ <austinwc@codeaurora.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jbrasen@codeaurora.org
Subject: Re: [PATCH v2] efi: capsule: allocate whole capsule into virtual memory
Date: Fri, 5 Aug 2016 12:46:53 +0100 [thread overview]
Message-ID: <20160805114653.GP3636@codeblueprint.co.uk> (raw)
In-Reply-To: <1469741429-17606-1-git-send-email-austinwc@codeaurora.org>
On Thu, 28 Jul, at 03:30:29PM, Christ, Austin wrote:
> According to UEFI 2.6 section 7.5.3, the capsule should be in contiguous
> virtual memory and firmware may consume the capsule immediately. To
> correctly implement this functionality, the kernel driver needs to vmap
> the entire capsule at the time it is made available to firmware.
>
> The virtual allocation of the capsule update has been changed from kmap,
> which was only allocating the first page of the update, to vmap, and
> allocates the entire data payload.
>
> Signed-off-by: Austin Christ <austinwc@codeaurora.org>
> Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
> Reviewed-by: Lee, Chun-Yi <jlee@suse.com>
> ---
> drivers/firmware/efi/capsule-loader.c | 8 +++++---
> drivers/firmware/efi/capsule.c | 6 +++---
> 2 files changed, 8 insertions(+), 6 deletions(-)
Thanks, applied.
prev parent reply other threads:[~2016-08-05 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 21:30 [PATCH v2] efi: capsule: allocate whole capsule into virtual memory Austin Christ
2016-08-05 11:46 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805114653.GP3636@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=austinwc@codeaurora.org \
--cc=jbrasen@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).