[PATCH 1/1] ASoc: simple-card-utils: add __printf attribute

[PATCH 1/1] ASoc: simple-card-utils: add __printf attribute

[Nicolas Iooss]

asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format
some of its arguments.  Adding a __printf attribute to this function
makes it possible to detect at compile-time errors related to format
strings.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
 include/sound/simple_card_utils.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h
index 86088aed9002..3207b1a70d38 100644
--- a/include/sound/simple_card_utils.h
+++ b/include/sound/simple_card_utils.h
@@ -27,6 +27,7 @@ int asoc_simple_card_parse_daifmt(struct device *dev,
 				  struct device_node *codec,
 				  char *prefix,
 				  unsigned int *retfmt);
+__printf(3, 4)
 int asoc_simple_card_set_dailink_name(struct device *dev,
 				      struct snd_soc_dai_link *dai_link,
 				      const char *fmt, ...);
-- 
2.9.2

Re: [PATCH 1/1] ASoc: simple-card-utils: add __printf attribute

[Nicolas Iooss]

Hello,

After I sent the following patch a few weeks ago, I have not received
any feedback. Could you please review it?

Thanks,
Nicolas

On 06/08/16 11:58, Nicolas Iooss wrote:
> asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format
> some of its arguments.  Adding a __printf attribute to this function
> makes it possible to detect at compile-time errors related to format
> strings.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
>  include/sound/simple_card_utils.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h
> index 86088aed9002..3207b1a70d38 100644
> --- a/include/sound/simple_card_utils.h
> +++ b/include/sound/simple_card_utils.h
> @@ -27,6 +27,7 @@ int asoc_simple_card_parse_daifmt(struct device *dev,
>  				  struct device_node *codec,
>  				  char *prefix,
>  				  unsigned int *retfmt);
> +__printf(3, 4)
>  int asoc_simple_card_set_dailink_name(struct device *dev,
>  				      struct snd_soc_dai_link *dai_link,
>  				      const char *fmt, ...);
> 

Re: [PATCH 1/1] ASoc: simple-card-utils: add __printf attribute

[Takashi Iwai]

On Mon, 22 Aug 2016 15:06:05 +0200,
Nicolas Iooss wrote:
> 
> Hello,
> 
> After I sent the following patch a few weeks ago, I have not received
> any feedback. Could you please review it?

This is about ASoC, so please resubmit to alsa-devel ML with Cc to the
ASoC maintainer (Mark) and the author of the code (Morimoto-san).

Also, please use the correct prefix "ASoC" in the subject line.


thanks,

Takashi

> 
> Thanks,
> Nicolas
> 
> On 06/08/16 11:58, Nicolas Iooss wrote:
> > asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format
> > some of its arguments.  Adding a __printf attribute to this function
> > makes it possible to detect at compile-time errors related to format
> > strings.
> > 
> > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> > ---
> >  include/sound/simple_card_utils.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h
> > index 86088aed9002..3207b1a70d38 100644
> > --- a/include/sound/simple_card_utils.h
> > +++ b/include/sound/simple_card_utils.h
> > @@ -27,6 +27,7 @@ int asoc_simple_card_parse_daifmt(struct device *dev,
> >  				  struct device_node *codec,
> >  				  char *prefix,
> >  				  unsigned int *retfmt);
> > +__printf(3, 4)
> >  int asoc_simple_card_set_dailink_name(struct device *dev,
> >  				      struct snd_soc_dai_link *dai_link,
> >  				      const char *fmt, ...);
> > 
> 
> 

Re: [PATCH 1/1] ASoc: simple-card-utils: add __printf attribute

[Nicolas Iooss]

On 22/08/16 15:13, Takashi Iwai wrote:
> On Mon, 22 Aug 2016 15:06:05 +0200,
> Nicolas Iooss wrote:
>>
>> Hello,
>>
>> After I sent the following patch a few weeks ago, I have not received
>> any feedback. Could you please review it?
>
> This is about ASoC, so please resubmit to alsa-devel ML with Cc to the
> ASoC maintainer (Mark) and the author of the code (Morimoto-san).

Thanks for your feedback. It seems that the ASoC entry in MAINTAINERS
does not include include/sound/simple_card_utils.h, which is why I sent
this patch to the wrong maintainers. I also did not sent it to
alsa-devel@alsa-project.org because this mailing list is moderated, but
I will subscribe to it.

> Also, please use the correct prefix "ASoC" in the subject line.

Oops, I will fix this.

Thanks again,
Nicolas

Re: [PATCH 1/1] ASoc: simple-card-utils: add __printf attribute

[Takashi Iwai]

On Mon, 22 Aug 2016 15:25:33 +0200,
Nicolas Iooss wrote:
> 
> On 22/08/16 15:13, Takashi Iwai wrote:
> > On Mon, 22 Aug 2016 15:06:05 +0200,
> > Nicolas Iooss wrote:
> >>
> >> Hello,
> >>
> >> After I sent the following patch a few weeks ago, I have not received
> >> any feedback. Could you please review it?
> >
> > This is about ASoC, so please resubmit to alsa-devel ML with Cc to the
> > ASoC maintainer (Mark) and the author of the code (Morimoto-san).
> 
> Thanks for your feedback. It seems that the ASoC entry in MAINTAINERS
> does not include include/sound/simple_card_utils.h, which is why I sent
> this patch to the wrong maintainers. I also did not sent it to
> alsa-devel@alsa-project.org because this mailing list is moderated, but
> I will subscribe to it.

FWIW, alsa-devel ML needs some manual approval at the first post from
an unknown person, so you can be just patient for a while.


Takashi