From: Chris Wilson <chris@chris-wilson.co.uk>
To: akash.goel@intel.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [PATCH] relay: Use per CPU constructs for the relay channel buffer pointers
Date: Thu, 11 Aug 2016 08:03:26 +0100 [thread overview]
Message-ID: <20160811070326.GA12148@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1470899140-21205-1-git-send-email-akash.goel@intel.com>
On Thu, Aug 11, 2016 at 12:35:40PM +0530, akash.goel@intel.com wrote:
> From: Akash Goel <akash.goel@intel.com>
>
> relay essentially needs to maintain the per CPU array of channel buffer
> pointers but it manually creates that array.
> Instead its better to avail the per CPU constructs, provided by the
> kernel, to allocate & access the array of pointer to channel buffers.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Akash Goel <akash.goel@intel.com>
This has the benefit of being a mechnical change and I could not think
of a better way to express the per-cpu indirection.
relay.h should probably include <linux/percpu.h> so that it pulls in
the percpu api explicitly.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2016-08-11 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 7:05 [PATCH] relay: Use per CPU constructs for the relay channel buffer pointers akash.goel
2016-08-11 7:03 ` Chris Wilson [this message]
2016-08-11 9:52 ` [PATCH v2] " akash.goel
2016-09-06 15:20 ` [tip:smp/hotplug] " tip-bot for Akash Goel
2016-09-06 16:37 ` tip-bot for Akash Goel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811070326.GA12148@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=akash.goel@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).