From: Catalin Marinas <catalin.marinas@arm.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Xie Yisheng <xieyisheng1@huawei.com>,
mark.rutland@arm.com, linux-mm@kvack.org, sudeep.holla@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
dave.hansen@intel.com, robh+dt@kernel.org, guohanjun@huawei.com,
akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com,
linux-arm-kernel@lists.infradead.org, mike.kravetz@oracle.com
Subject: Re: [RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page
Date: Mon, 22 Aug 2016 11:00:45 +0100 [thread overview]
Message-ID: <20160822100045.GA26494@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <20160822080358.GF13596@dhcp22.suse.cz>
On Mon, Aug 22, 2016 at 10:03:58AM +0200, Michal Hocko wrote:
> On Mon 22-08-16 10:56:43, Xie Yisheng wrote:
> > Arm64 supports gigantic page after
> > commit 084bd29810a5 ("ARM64: mm: HugeTLB support.")
> > however, it got broken by
> > commit 944d9fec8d7a ("hugetlb: add support for gigantic page
> > allocation at runtime")
> >
> > This patch selects ARCH_HAS_GIGANTIC_PAGE to make this
> > function can be used again.
>
> I haven't double checked that the above commit really broke it but if
> that is the case then
>
> Fixes: 944d9fec8d7a ("hugetlb: add support for gigantic page allocation at runtime")
>
> would be nice as well I guess. I do not think that marking it for stable
> is really necessary considering how long it's been broken and nobody has
> noticed...
I'm not sure that commit broke it. The gigantic functionality introduced
by the above commit was under an #ifdef CONFIG_X86_64. Prior
to that we had a VM_BUG_ON(hstate_is_gigantic(h)).
--
Catalin
next prev parent reply other threads:[~2016-08-22 10:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 2:56 [RFC PATCH v2 0/2] arm64/hugetlb: enable gigantic page Xie Yisheng
2016-08-22 2:56 ` [RFC PATCH v2 1/2] mm/hugetlb: Introduce ARCH_HAS_GIGANTIC_PAGE Xie Yisheng
2016-08-22 8:01 ` Michal Hocko
2016-08-22 10:37 ` Yisheng Xie
2016-08-22 2:56 ` [RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page Xie Yisheng
2016-08-22 8:03 ` Michal Hocko
2016-08-22 10:00 ` Catalin Marinas [this message]
2016-08-22 11:33 ` Yisheng Xie
2016-08-22 10:21 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822100045.GA26494@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=guohanjun@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will.deacon@arm.com \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).