From: Yisheng Xie <xieyisheng1@huawei.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: <akpm@linux-foundation.org>, <guohanjun@huawei.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<will.deacon@arm.com>, <dave.hansen@intel.com>,
<sudeep.holla@arm.com>, <catalin.marinas@arm.com>,
<mark.rutland@arm.com>, <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <mike.kravetz@oracle.com>,
<n-horiguchi@ah.jp.nec.com>
Subject: Re: [RFC PATCH v2 1/2] mm/hugetlb: Introduce ARCH_HAS_GIGANTIC_PAGE
Date: Mon, 22 Aug 2016 18:37:58 +0800 [thread overview]
Message-ID: <32ed1cea-df4b-a170-2d6f-0a4e05ee8405@huawei.com> (raw)
In-Reply-To: <20160822080101.GE13596@dhcp22.suse.cz>
On 2016/8/22 16:01, Michal Hocko wrote:
> On Mon 22-08-16 10:56:42, Xie Yisheng wrote:
>>
>> +config ARCH_HAS_GIGANTIC_PAGE
>> + depends on HUGETLB_PAGE
>> + bool
>> +
>
> but is this really necessary? The code where we use
> ARCH_HAS_GIGANTIC_PAGE already depends on HUGETLB_PAGE.
>
Hi Michal,
Thank you for your reply.
That right, it's no need to depends on HUGETLB_PAGE here.
I will send v3 soon.
Thanks
Xie Yisheng
> Other than that looks good to me and a nice simplification.
>
>> source "fs/configfs/Kconfig"
>> source "fs/efivarfs/Kconfig"
>>
>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
>> index 87e11d8..8488dcc 100644
>> --- a/mm/hugetlb.c
>> +++ b/mm/hugetlb.c
>> @@ -1022,7 +1022,7 @@ static int hstate_next_node_to_free(struct hstate *h, nodemask_t *nodes_allowed)
>> ((node = hstate_next_node_to_free(hs, mask)) || 1); \
>> nr_nodes--)
>>
>> -#if (defined(CONFIG_X86_64) || defined(CONFIG_S390)) && \
>> +#if defined(CONFIG_ARCH_HAS_GIGANTIC_PAGE) && \
>> ((defined(CONFIG_MEMORY_ISOLATION) && defined(CONFIG_COMPACTION)) || \
>> defined(CONFIG_CMA))
>> static void destroy_compound_gigantic_page(struct page *page,
>> --
>> 1.7.12.4
>
next prev parent reply other threads:[~2016-08-22 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 2:56 [RFC PATCH v2 0/2] arm64/hugetlb: enable gigantic page Xie Yisheng
2016-08-22 2:56 ` [RFC PATCH v2 1/2] mm/hugetlb: Introduce ARCH_HAS_GIGANTIC_PAGE Xie Yisheng
2016-08-22 8:01 ` Michal Hocko
2016-08-22 10:37 ` Yisheng Xie [this message]
2016-08-22 2:56 ` [RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page Xie Yisheng
2016-08-22 8:03 ` Michal Hocko
2016-08-22 10:00 ` Catalin Marinas
2016-08-22 11:33 ` Yisheng Xie
2016-08-22 10:21 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32ed1cea-df4b-a170-2d6f-0a4e05ee8405@huawei.com \
--to=xieyisheng1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@intel.com \
--cc=guohanjun@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).