linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1 linux-next] iommu/amd: remove AMD_IOMMU_STATS
@ 2016-08-12 21:54 Fabian Frederick
  2016-08-22 10:50 ` Joerg Roedel
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2016-08-12 21:54 UTC (permalink / raw)
  To: Joerg Roedel, Ingo Molnar; +Cc: linux-kernel, fabf

Commit e85e8f69cedb
("iommu/amd: Remove statistics code")
removed that config.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 arch/x86/configs/x86_64_defconfig | 1 -
 drivers/iommu/amd_iommu_proto.h   | 4 ----
 2 files changed, 5 deletions(-)

diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
index d28bdab..7ef4a09 100644
--- a/arch/x86/configs/x86_64_defconfig
+++ b/arch/x86/configs/x86_64_defconfig
@@ -255,7 +255,6 @@ CONFIG_RTC_CLASS=y
 CONFIG_DMADEVICES=y
 CONFIG_EEEPC_LAPTOP=y
 CONFIG_AMD_IOMMU=y
-CONFIG_AMD_IOMMU_STATS=y
 CONFIG_INTEL_IOMMU=y
 # CONFIG_INTEL_IOMMU_DEFAULT_ON is not set
 CONFIG_EFI_VARS=y
diff --git a/drivers/iommu/amd_iommu_proto.h b/drivers/iommu/amd_iommu_proto.h
index 0bd9eb3..697bccc 100644
--- a/drivers/iommu/amd_iommu_proto.h
+++ b/drivers/iommu/amd_iommu_proto.h
@@ -78,12 +78,8 @@ static inline int amd_iommu_create_irq_domain(struct amd_iommu *iommu)
 extern int amd_iommu_complete_ppr(struct pci_dev *pdev, int pasid,
 				  int status, int tag);
 
-#ifndef CONFIG_AMD_IOMMU_STATS
-
 static inline void amd_iommu_stats_init(void) { }
 
-#endif /* !CONFIG_AMD_IOMMU_STATS */
-
 static inline bool is_rd890_iommu(struct pci_dev *pdev)
 {
 	return (pdev->vendor == PCI_VENDOR_ID_ATI) &&
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1 linux-next] iommu/amd: remove AMD_IOMMU_STATS
  2016-08-12 21:54 [PATCH 1/1 linux-next] iommu/amd: remove AMD_IOMMU_STATS Fabian Frederick
@ 2016-08-22 10:50 ` Joerg Roedel
  0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2016-08-22 10:50 UTC (permalink / raw)
  To: Fabian Frederick; +Cc: Ingo Molnar, linux-kernel

On Fri, Aug 12, 2016 at 11:54:47PM +0200, Fabian Frederick wrote:
> Commit e85e8f69cedb
> ("iommu/amd: Remove statistics code")
> removed that config.
> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  arch/x86/configs/x86_64_defconfig | 1 -
>  drivers/iommu/amd_iommu_proto.h   | 4 ----
>  2 files changed, 5 deletions(-)
> 
> diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
> index d28bdab..7ef4a09 100644
> --- a/arch/x86/configs/x86_64_defconfig
> +++ b/arch/x86/configs/x86_64_defconfig
> @@ -255,7 +255,6 @@ CONFIG_RTC_CLASS=y
>  CONFIG_DMADEVICES=y
>  CONFIG_EEEPC_LAPTOP=y
>  CONFIG_AMD_IOMMU=y
> -CONFIG_AMD_IOMMU_STATS=y
>  CONFIG_INTEL_IOMMU=y
>  # CONFIG_INTEL_IOMMU_DEFAULT_ON is not set
>  CONFIG_EFI_VARS=y
> diff --git a/drivers/iommu/amd_iommu_proto.h b/drivers/iommu/amd_iommu_proto.h
> index 0bd9eb3..697bccc 100644
> --- a/drivers/iommu/amd_iommu_proto.h
> +++ b/drivers/iommu/amd_iommu_proto.h
> @@ -78,12 +78,8 @@ static inline int amd_iommu_create_irq_domain(struct amd_iommu *iommu)
>  extern int amd_iommu_complete_ppr(struct pci_dev *pdev, int pasid,
>  				  int status, int tag);
>  
> -#ifndef CONFIG_AMD_IOMMU_STATS
> -
>  static inline void amd_iommu_stats_init(void) { }

That function can be removed too, while you are at it. Thanks for
cleaning that up.


	Joerg

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-22 10:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-12 21:54 [PATCH 1/1 linux-next] iommu/amd: remove AMD_IOMMU_STATS Fabian Frederick
2016-08-22 10:50 ` Joerg Roedel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).