* [PATCH -next] irqchip/irq-jcore-aic: fix non static symbol warning
@ 2016-08-20 15:26 Wei Yongjun
2016-08-22 23:11 ` Jason Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-08-20 15:26 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier; +Cc: Wei Yongjun, linux-kernel
Fixes the following sparse warning:
drivers/irqchip/irq-jcore-aic.c:47:12: warning:
symbol 'aic_irq_of_init' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/irqchip/irq-jcore-aic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-jcore-aic.c b/drivers/irqchip/irq-jcore-aic.c
index 5e5e3bb..84b01de 100644
--- a/drivers/irqchip/irq-jcore-aic.c
+++ b/drivers/irqchip/irq-jcore-aic.c
@@ -44,7 +44,8 @@ static void noop(struct irq_data *data)
{
}
-int __init aic_irq_of_init(struct device_node *node, struct device_node *parent)
+static int __init aic_irq_of_init(struct device_node *node,
+ struct device_node *parent)
{
unsigned min_irq = JCORE_AIC2_MIN_HWIRQ;
unsigned dom_sz = JCORE_AIC_MAX_HWIRQ+1;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] irqchip/irq-jcore-aic: fix non static symbol warning
2016-08-20 15:26 [PATCH -next] irqchip/irq-jcore-aic: fix non static symbol warning Wei Yongjun
@ 2016-08-22 23:11 ` Jason Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Jason Cooper @ 2016-08-22 23:11 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Thomas Gleixner, Marc Zyngier, linux-kernel
Hi Wei Yongjun,
On Sat, Aug 20, 2016 at 03:26:28PM +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/irqchip/irq-jcore-aic.c:47:12: warning:
> symbol 'aic_irq_of_init' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
> ---
> drivers/irqchip/irq-jcore-aic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to irqchip/jcore,
thx,
Jason.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-22 23:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-20 15:26 [PATCH -next] irqchip/irq-jcore-aic: fix non static symbol warning Wei Yongjun
2016-08-22 23:11 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).