* [PATCH] staging:xgifb:remove unused code
[not found] <1471936942-15631-1-git-send-email-dingxiang@huawei.com>
@ 2016-08-23 7:26 ` dingxiang
2016-08-23 8:07 ` Sudip Mukherjee
0 siblings, 1 reply; 2+ messages in thread
From: dingxiang @ 2016-08-23 7:26 UTC (permalink / raw)
To: arnaud.patard, gregkh; +Cc: devel, linux-kernel
The variable data is assigned but never used in rest code.
Signed-off-by: Ding Xiang <dingxiang@huawei.com>
---
drivers/staging/xgifb/vb_setmode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 50c8ea4..71bb9ca 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex,
tempax |= 0x40;
xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax);
- data = xgifb_reg_get(pVBInfo->P3d4, 0x07);
tempax = 0;
if (tempbx & 0x04)
--
2.5.0
.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging:xgifb:remove unused code
2016-08-23 7:26 ` [PATCH] staging:xgifb:remove unused code dingxiang
@ 2016-08-23 8:07 ` Sudip Mukherjee
0 siblings, 0 replies; 2+ messages in thread
From: Sudip Mukherjee @ 2016-08-23 8:07 UTC (permalink / raw)
To: dingxiang; +Cc: arnaud.patard, gregkh, devel, linux-kernel
On Tue, Aug 23, 2016 at 03:26:50PM +0800, dingxiang wrote:
> The variable data is assigned but never used in rest code.
>
> Signed-off-by: Ding Xiang <dingxiang@huawei.com>
> ---
Your name in Signed-off-by: and From: doesnot match.
> drivers/staging/xgifb/vb_setmode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 50c8ea4..71bb9ca 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex,
> tempax |= 0x40;
> xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax);
> - data = xgifb_reg_get(pVBInfo->P3d4, 0x07);
> tempax = 0;
> if (tempbx & 0x04)
The patch will not apply. Its missing two blank lines which the original
code has.
regards
sudip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-23 8:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1471936942-15631-1-git-send-email-dingxiang@huawei.com>
2016-08-23 7:26 ` [PATCH] staging:xgifb:remove unused code dingxiang
2016-08-23 8:07 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).