* [PATCH resend] staging:xgifb:remove unused code
@ 2016-08-23 9:17 Ding Xiang
2016-08-23 9:29 ` Sudip Mukherjee
2016-08-23 10:23 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Ding Xiang @ 2016-08-23 9:17 UTC (permalink / raw)
To: arnaud.patard, gregkh; +Cc: devel, linux-kernel
The variable data is assigned but never used in rest code.
Signed-off-by: Ding Xiang <dingxiang@huawei.com>
---
drivers/staging/xgifb/vb_setmode.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 50c8ea4..71bb9ca 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex,
tempax |= 0x40;
xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax);
- data = xgifb_reg_get(pVBInfo->P3d4, 0x07);
tempax = 0;
if (tempbx & 0x04)
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH resend] staging:xgifb:remove unused code
2016-08-23 9:17 [PATCH resend] staging:xgifb:remove unused code Ding Xiang
@ 2016-08-23 9:29 ` Sudip Mukherjee
2016-08-23 10:23 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2016-08-23 9:29 UTC (permalink / raw)
To: Ding Xiang; +Cc: arnaud.patard, gregkh, devel, linux-kernel
On Tue, Aug 23, 2016 at 05:17:30PM +0800, Ding Xiang wrote:
> The variable data is assigned but never used in rest code.
>
> Signed-off-by: Ding Xiang <dingxiang@huawei.com>
> ---
The subject should have been [Patch v2] not resend.
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH resend] staging:xgifb:remove unused code
2016-08-23 9:17 [PATCH resend] staging:xgifb:remove unused code Ding Xiang
2016-08-23 9:29 ` Sudip Mukherjee
@ 2016-08-23 10:23 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-08-23 10:23 UTC (permalink / raw)
To: Ding Xiang; +Cc: arnaud.patard, devel, linux-kernel
On Tue, Aug 23, 2016 at 05:17:30PM +0800, Ding Xiang wrote:
> The variable data is assigned but never used in rest code.
>
> Signed-off-by: Ding Xiang <dingxiang@huawei.com>
> ---
> drivers/staging/xgifb/vb_setmode.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 50c8ea4..71bb9ca 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex,
> tempax |= 0x40;
>
> xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax);
> - data = xgifb_reg_get(pVBInfo->P3d4, 0x07);
But this did something with the hardware, are you sure this doesn't
break anything? Lots of hardware works with the sequence of:
write something
read something to make sure the write worked.
Did you test this?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-23 10:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-23 9:17 [PATCH resend] staging:xgifb:remove unused code Ding Xiang
2016-08-23 9:29 ` Sudip Mukherjee
2016-08-23 10:23 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).