From: Michal Hocko <firstname.lastname@example.org> To: Joonsoo Kim <email@example.com> Cc: Aruna Ramakrishna <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, Mike Kravetz <email@example.com>, Christoph Lameter <firstname.lastname@example.org>, Pekka Enberg <email@example.com>, David Rientjes <firstname.lastname@example.org>, Andrew Morton <email@example.com>, Mel Gorman <firstname.lastname@example.org>, Jiri Slaby <email@example.com> Subject: Re: what is the purpose of SLAB and SLUB (was: Re: [PATCH v3] mm/slab: Improve performance of gathering slabinfo) stats Date: Wed, 24 Aug 2016 10:05:36 +0200 [thread overview] Message-ID: <20160824080536.GD31179@dhcp22.suse.cz> (raw) In-Reply-To: <20160824011501.GA21997@js1304-P5Q-DELUXE> On Wed 24-08-16 10:15:02, Joonsoo Kim wrote: > On Tue, Aug 23, 2016 at 05:38:08PM +0200, Michal Hocko wrote: > > On Tue 23-08-16 11:13:03, Joonsoo Kim wrote: > > > On Thu, Aug 18, 2016 at 01:52:19PM +0200, Michal Hocko wrote: > > [...] > > > > I am not opposing the patch (to be honest it is quite neat) but this > > > > is buggering me for quite some time. Sorry for hijacking this email > > > > thread but I couldn't resist. Why are we trying to optimize SLAB and > > > > slowly converge it to SLUB feature-wise. I always thought that SLAB > > > > should remain stable and time challenged solution which works reasonably > > > > well for many/most workloads, while SLUB is an optimized implementation > > > > which experiment with slightly different concepts that might boost the > > > > performance considerably but might also surprise from time to time. If > > > > this is not the case then why do we have both of them in the kernel. It > > > > is a lot of code and some features need tweaking both while only one > > > > gets testing coverage. So this is mainly a question for maintainers. Why > > > > do we maintain both and what is the purpose of them. > > > > > > I don't know full history about it since I joined kernel communitiy > > > recently(?). Christoph would be a better candidate for this topic. > > > Anyway, > > > > > > SLAB if SLUB beats SLAB completely. But, there are fundamental > > > differences in implementation detail so they cannot beat each other > > > for all the workloads. It is similar with filesystem case that various > > > filesystems exist for it's own workload. > > > > Do we have any documentation/study about which particular workloads > > benefit from which allocator? It seems that most users will use whatever > > the default or what their distribution uses. E.g. SLES kernel use SLAB > > because this is what we used to have for ages and there was no strong > > reason to change that default. From such a perspective having a stable > > allocator with minimum changes - just bug fixes - makes a lot of sense. > > It doesn't make sense to me. Even if someone uses SLAB due to > conventional reason, they would want to use shiny new feature and get > performance improvement. > > And, it is not only reason to use SLAB. There would be many different > reasons to use SLAB. Could you be more specific please? Are there any inherent problems that would make one allocator unsuitable for specific workloads? > > I remember Mel doing some benchmarks when "why opensuse kernels do not > > use the default SLUB allocator" came the last time and he didn't see any > > large winner there > > https://lists.opensuse.org/opensuse-kernel/2015-08/msg00098.html > > This set of workloads is of course not comprehensive to rule one or > > other but I am wondering whether there are still any pathological > > workloads where we really want to keep SLAB or add new features to it. > > AFAIK, some network benchmark still shows regression in SLUB. > > http://firstname.lastname@example.org That suggests that this is not an inherent problem of SLUB though. -- Michal Hocko SUSE Labs
next prev parent reply other threads:[~2016-08-24 8:06 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-17 18:20 [PATCH v3] mm/slab: Improve performance of gathering slabinfo stats Aruna Ramakrishna 2016-08-17 19:03 ` Eric Dumazet 2016-08-17 19:25 ` Aruna Ramakrishna 2016-08-18 11:52 ` Michal Hocko 2016-08-19 5:47 ` aruna.ramakrishna 2016-08-23 2:13 ` Joonsoo Kim 2016-08-23 15:38 ` what is the purpose of SLAB and SLUB (was: Re: [PATCH v3] mm/slab: Improve performance of gathering slabinfo) stats Michal Hocko 2016-08-23 15:54 ` what is the purpose of SLAB and SLUB Andi Kleen 2016-08-25 4:10 ` Christoph Lameter 2016-08-25 7:32 ` Michal Hocko 2016-08-25 19:49 ` Christoph Lameter 2016-08-24 1:15 ` what is the purpose of SLAB and SLUB (was: Re: [PATCH v3] mm/slab: Improve performance of gathering slabinfo) stats Joonsoo Kim 2016-08-24 8:05 ` Michal Hocko [this message] 2016-08-24 8:20 ` Mel Gorman 2016-08-25 4:01 ` Christoph Lameter 2016-08-25 10:07 ` Mel Gorman 2016-08-25 19:55 ` Christoph Lameter 2016-08-26 20:47 ` what is the purpose of SLAB and SLUB Andi Kleen 2016-08-29 13:44 ` Michal Hocko 2016-08-29 14:49 ` Christoph Lameter 2016-08-30 9:39 ` what is the purpose of SLAB and SLUB (was: Re: [PATCH v3] mm/slab: Improve performance of gathering slabinfo) stats Mel Gorman 2016-08-30 19:32 ` Christoph Lameter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160824080536.GD31179@dhcp22.suse.cz \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: what is the purpose of SLAB and SLUB (was: Re: [PATCH v3] mm/slab: Improve performance of gathering slabinfo) stats' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).