From: firstname.lastname@example.org To: Michal Hocko <email@example.com> Cc: firstname.lastname@example.org, email@example.com, Mike Kravetz <firstname.lastname@example.org>, Christoph Lameter <email@example.com>, Pekka Enberg <firstname.lastname@example.org>, David Rientjes <email@example.com>, Joonsoo Kim <firstname.lastname@example.org>, Andrew Morton <email@example.com> Subject: Re: [PATCH v3] mm/slab: Improve performance of gathering slabinfo stats Date: Thu, 18 Aug 2016 22:47:59 -0700 [thread overview] Message-ID: <57B69D8F.firstname.lastname@example.org> (raw) In-Reply-To: <20160818115218.GJ30162@dhcp22.suse.cz> On 08/18/2016 04:52 AM, Michal Hocko wrote: > I am not opposing the patch (to be honest it is quite neat) but this > is buggering me for quite some time. Sorry for hijacking this email > thread but I couldn't resist. Why are we trying to optimize SLAB and > slowly converge it to SLUB feature-wise. I always thought that SLAB > should remain stable and time challenged solution which works reasonably > well for many/most workloads, while SLUB is an optimized implementation > which experiment with slightly different concepts that might boost the > performance considerably but might also surprise from time to time. If > this is not the case then why do we have both of them in the kernel. It > is a lot of code and some features need tweaking both while only one > gets testing coverage. So this is mainly a question for maintainers. Why > do we maintain both and what is the purpose of them. Michal, Speaking about this patch specifically - I'm not trying to optimize SLAB or make it more similar to SLUB. This patch is a bug fix for an issue where the slowness of 'cat /proc/slabinfo' caused timeouts in other drivers. While optimizing that flow, it became apparent (as Christoph pointed out) that one could converge this patch to SLUB's current implementation. Though I have not done that in this patch (because that warrants a separate patch), I think it makes sense to converge where appropriate, since they both do share some common data structures and code already. Thanks, Aruna
next prev parent reply other threads:[~2016-08-19 5:48 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-17 18:20 Aruna Ramakrishna 2016-08-17 19:03 ` Eric Dumazet 2016-08-17 19:25 ` Aruna Ramakrishna 2016-08-18 11:52 ` Michal Hocko 2016-08-19 5:47 ` aruna.ramakrishna [this message] 2016-08-23 2:13 ` Joonsoo Kim 2016-08-23 15:38 ` what is the purpose of SLAB and SLUB (was: Re: [PATCH v3] mm/slab: Improve performance of gathering slabinfo) stats Michal Hocko 2016-08-23 15:54 ` what is the purpose of SLAB and SLUB Andi Kleen 2016-08-25 4:10 ` Christoph Lameter 2016-08-25 7:32 ` Michal Hocko 2016-08-25 19:49 ` Christoph Lameter 2016-08-24 1:15 ` what is the purpose of SLAB and SLUB (was: Re: [PATCH v3] mm/slab: Improve performance of gathering slabinfo) stats Joonsoo Kim 2016-08-24 8:05 ` Michal Hocko 2016-08-24 8:20 ` Mel Gorman 2016-08-25 4:01 ` Christoph Lameter 2016-08-25 10:07 ` Mel Gorman 2016-08-25 19:55 ` Christoph Lameter 2016-08-26 20:47 ` what is the purpose of SLAB and SLUB Andi Kleen 2016-08-29 13:44 ` Michal Hocko 2016-08-29 14:49 ` Christoph Lameter 2016-08-30 9:39 ` what is the purpose of SLAB and SLUB (was: Re: [PATCH v3] mm/slab: Improve performance of gathering slabinfo) stats Mel Gorman 2016-08-30 19:32 ` Christoph Lameter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=57B69D8F.email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v3] mm/slab: Improve performance of gathering slabinfo stats' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).