From: Christoph Hellwig <hch@lst.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Christoph Hellwig <hch@lst.de>, Andy Lutomirski <luto@kernel.org>,
Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] nvme: Fix nvme_get/set_features() with a NULL result pointer
Date: Thu, 25 Aug 2016 10:27:27 +0200 [thread overview]
Message-ID: <20160825082727.GA20497@lst.de> (raw)
In-Reply-To: <CALCETrWsJCwO6D9=LsYOV5ghbXMc_MdOYgXm1qzarJ1-cizuXw@mail.gmail.com>
On Thu, Aug 25, 2016 at 12:54:00AM -0700, Andy Lutomirski wrote:
> I am, and I have a patch to do the former (and to add a length
> argument). But that's not -stable material.
Great!
> While I have your attention: the new use is to enable APST (power
> saving). In theory, it seems like I should integrate with dev_pm_qos
> so that the standard interface for setting a latency limit will work,
> but, on brief inspection, there are literally no drivers in the entire
> tree that do this. Am I missing something? My current draft patch
> just adds a sysfs attribute. (It saves a *lot* of power on my laptop,
> so supporting APST is worth doing.)
I'm proably the wrong person to talk about PM interfaces, but not
having it used anywhere is a red herring and needs a ping to the PM
folks why we even have that code in the tree.
Integrating it with the PM core would be preferable, but until that
happens we should just enable it by default in the nvme driver and
have a local tweak (sysfs file, or maybe even just a run-time writeable
module parameter) to turn it off.
next prev parent reply other threads:[~2016-08-25 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 10:52 [PATCH] nvme: Fix nvme_get/set_features() with a NULL result pointer Andy Lutomirski
2016-08-24 11:04 ` Sagi Grimberg
2016-08-24 14:11 ` Jens Axboe
2016-08-25 7:38 ` Christoph Hellwig
2016-08-25 7:54 ` Andy Lutomirski
2016-08-25 8:27 ` Christoph Hellwig [this message]
2016-08-25 14:20 ` Jens Axboe
2016-08-26 14:31 ` Andy Lutomirski
2016-08-26 14:35 ` Christoph Hellwig
2016-08-26 15:17 ` Keith Busch
2016-08-26 15:12 ` Jens Axboe
2016-08-26 15:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825082727.GA20497@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).