From: Jens Axboe <axboe@fb.com>
To: Andy Lutomirski <luto@kernel.org>, Keith Busch <keith.busch@intel.com>
Cc: <linux-nvme@lists.infradead.org>, Christoph Hellwig <hch@lst.de>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] nvme: Fix nvme_get/set_features() with a NULL result pointer
Date: Wed, 24 Aug 2016 08:11:27 -0600 [thread overview]
Message-ID: <9f297b01-8f01-3d09-1de9-8be0d5ff007c@fb.com> (raw)
In-Reply-To: <f0eca21161c9ec5f81e9591741463ec3883cb931.1472035881.git.luto@kernel.org>
On 08/24/2016 04:52 AM, Andy Lutomirski wrote:
> nvme_set_features() callers seem to expect that passing NULL as the
> result pointer is acceptable. Teach nvme_set_features() not to try to
> write to the NULL address.
>
> For symmetry, make the same change to nvme_get_features(), despite the
> fact that all current callers pass a valid result pointer.
>
> I assume that this bug hasn't been reported in practice because
> the callers that pass NULL are all in the SCSI translation layer
> and no one uses the relevant operations.
Thanks, applied for 4.8.
--
Jens Axboe
next prev parent reply other threads:[~2016-08-24 14:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 10:52 [PATCH] nvme: Fix nvme_get/set_features() with a NULL result pointer Andy Lutomirski
2016-08-24 11:04 ` Sagi Grimberg
2016-08-24 14:11 ` Jens Axboe [this message]
2016-08-25 7:38 ` Christoph Hellwig
2016-08-25 7:54 ` Andy Lutomirski
2016-08-25 8:27 ` Christoph Hellwig
2016-08-25 14:20 ` Jens Axboe
2016-08-26 14:31 ` Andy Lutomirski
2016-08-26 14:35 ` Christoph Hellwig
2016-08-26 15:17 ` Keith Busch
2016-08-26 15:12 ` Jens Axboe
2016-08-26 15:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f297b01-8f01-3d09-1de9-8be0d5ff007c@fb.com \
--to=axboe@fb.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=luto@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).