* [PATCH] fix:memory:of_memory:add missing header dependencies
@ 2016-08-27 17:31 Baoyou Xie
2016-08-27 17:54 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Baoyou Xie @ 2016-08-27 17:31 UTC (permalink / raw)
To: gregkh, dan.carpenter; +Cc: linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 2 warnings when biuld kernel with W=1:
drivers/memory/of_memory.c:30:30: warning: no previous prototype for 'of_get_min_tck' [-Wmissing-prototypes]
drivers/memory/of_memory.c:106:30: warning: no previous prototype for 'of_get_ddr_timings' [-Wmissing-prototypes]
In fact, these functions are declared in drivers/memory/of_memory.h
so this patch add missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/memory/of_memory.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/memory/of_memory.c b/drivers/memory/of_memory.c
index 9daf94b..568f05e 100644
--- a/drivers/memory/of_memory.c
+++ b/drivers/memory/of_memory.c
@@ -16,6 +16,7 @@
#include <linux/gfp.h>
#include <memory/jedec_ddr.h>
#include <linux/export.h>
+#include "of_memory.h"
/**
* of_get_min_tck() - extract min timing values for ddr
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fix:memory:of_memory:add missing header dependencies
2016-08-27 17:31 [PATCH] fix:memory:of_memory:add missing header dependencies Baoyou Xie
@ 2016-08-27 17:54 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-08-27 17:54 UTC (permalink / raw)
To: Baoyou Xie; +Cc: dan.carpenter, linux-kernel, arnd, xie.baoyou
On Sun, Aug 28, 2016 at 01:31:28AM +0800, Baoyou Xie wrote:
> We get 2 warnings when biuld kernel with W=1:
Why would you do that?
> drivers/memory/of_memory.c:30:30: warning: no previous prototype for 'of_get_min_tck' [-Wmissing-prototypes]
> drivers/memory/of_memory.c:106:30: warning: no previous prototype for 'of_get_ddr_timings' [-Wmissing-prototypes]
>
> In fact, these functions are declared in drivers/memory/of_memory.h
> so this patch add missing header dependencies.
Why am I not seeing this warning on a "normal" build? If there's no
prototype of a function, that seems odd... What about sparse, does that
give you the same error here?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-27 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-27 17:31 [PATCH] fix:memory:of_memory:add missing header dependencies Baoyou Xie
2016-08-27 17:54 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).