* [PATCH] Bluetooth: add WCNSS dependency for HCI driver
@ 2016-08-29 12:36 Arnd Bergmann
2016-08-29 14:07 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-08-29 12:36 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Bjorn Andersson, Arnd Bergmann, Gustavo Padovan, Johan Hedberg,
linux-bluetooth, linux-kernel
The newly added bluetooth driver is based on the soc-specific support,
but lacks the obvious compile-time dependency on that:
drivers/bluetooth/btqcomsmd.o: In function `btqcomsmd_probe':
btqcomsmd.c:(.text.btqcomsmd_probe+0x40): undefined reference to `qcom_wcnss_open_channel'
btqcomsmd.c:(.text.btqcomsmd_probe+0x5c): undefined reference to `qcom_wcnss_open_channel'
Makefile:969: recipe for target 'vmlinux' failed
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 90c107dc8b2c ("Bluetooth: Introduce Qualcomm WCNSS SMD based HCI driver")
---
drivers/bluetooth/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 2c481911f1ce..43e9f9328df8 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -333,7 +333,7 @@ config BT_WILINK
config BT_QCOMSMD
tristate "Qualcomm SMD based HCI support"
- depends on QCOM_SMD
+ depends on QCOM_SMD && QCOM_WCNSS_CTRL
select BT_QCA
help
Qualcomm SMD based HCI driver.
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: add WCNSS dependency for HCI driver
2016-08-29 12:36 [PATCH] Bluetooth: add WCNSS dependency for HCI driver Arnd Bergmann
@ 2016-08-29 14:07 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2016-08-29 14:07 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bjorn Andersson, Gustavo F. Padovan, Johan Hedberg,
open list:BLUETOOTH DRIVERS, linux-kernel
Hi Arnd,
> The newly added bluetooth driver is based on the soc-specific support,
> but lacks the obvious compile-time dependency on that:
>
> drivers/bluetooth/btqcomsmd.o: In function `btqcomsmd_probe':
> btqcomsmd.c:(.text.btqcomsmd_probe+0x40): undefined reference to `qcom_wcnss_open_channel'
> btqcomsmd.c:(.text.btqcomsmd_probe+0x5c): undefined reference to `qcom_wcnss_open_channel'
> Makefile:969: recipe for target 'vmlinux' failed
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 90c107dc8b2c ("Bluetooth: Introduce Qualcomm WCNSS SMD based HCI driver")
> ---
> drivers/bluetooth/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-29 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-29 12:36 [PATCH] Bluetooth: add WCNSS dependency for HCI driver Arnd Bergmann
2016-08-29 14:07 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).