* [PATCH 0/2] phy: rcar-gen3-usb2: revise the dt doc and add support for r8a7796
@ 2016-08-24 6:49 Yoshihiro Shimoda
2016-08-24 6:49 ` [PATCH 1/2] phy: rcar-gen3-usb2: revise the example of device tree doc Yoshihiro Shimoda
2016-08-24 6:49 ` [PATCH 2/2] phy: rcar-gen3-usb2: Add a compatible string for r8a7796 Yoshihiro Shimoda
0 siblings, 2 replies; 7+ messages in thread
From: Yoshihiro Shimoda @ 2016-08-24 6:49 UTC (permalink / raw)
To: kishon, robh+dt, mark.rutland
Cc: linux-kernel, devicetree, linux-renesas-soc, Yoshihiro Shimoda
This patch set is based on the latest linux-phy.git / next branch.
(commit id = d9a6e11e10d657df9af1d321c0eccdead184f72a)
Yoshihiro Shimoda (2):
phy: rcar-gen3-usb2: revise the example of device tree doc
phy: rcar-gen3-usb2: Add a compatible string for r8a7796
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 6 ++++--
drivers/phy/phy-rcar-gen3-usb2.c | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] phy: rcar-gen3-usb2: revise the example of device tree doc
2016-08-24 6:49 [PATCH 0/2] phy: rcar-gen3-usb2: revise the dt doc and add support for r8a7796 Yoshihiro Shimoda
@ 2016-08-24 6:49 ` Yoshihiro Shimoda
2016-08-25 8:29 ` Geert Uytterhoeven
2016-08-29 15:51 ` Rob Herring
2016-08-24 6:49 ` [PATCH 2/2] phy: rcar-gen3-usb2: Add a compatible string for r8a7796 Yoshihiro Shimoda
1 sibling, 2 replies; 7+ messages in thread
From: Yoshihiro Shimoda @ 2016-08-24 6:49 UTC (permalink / raw)
To: kishon, robh+dt, mark.rutland
Cc: linux-kernel, devicetree, linux-renesas-soc, Yoshihiro Shimoda
The clocks property should be set to &cpg, not &mstpX_clks.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
index 2281d6c..b54fb36 100644
--- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
+++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
@@ -30,11 +30,11 @@ Example (R-Car H3):
compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
reg = <0 0xee080200 0 0x700>;
interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&mstp7_clks R8A7795_CLK_EHCI0>;
+ clocks = <&cpg CPG_MOD 703>;
};
usb-phy@ee0a0200 {
compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
reg = <0 0xee0a0200 0 0x700>;
- clocks = <&mstp7_clks R8A7795_CLK_EHCI0>;
+ clocks = <&cpg CPG_MOD 702>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] phy: rcar-gen3-usb2: Add a compatible string for r8a7796
2016-08-24 6:49 [PATCH 0/2] phy: rcar-gen3-usb2: revise the dt doc and add support for r8a7796 Yoshihiro Shimoda
2016-08-24 6:49 ` [PATCH 1/2] phy: rcar-gen3-usb2: revise the example of device tree doc Yoshihiro Shimoda
@ 2016-08-24 6:49 ` Yoshihiro Shimoda
2016-08-25 8:23 ` Geert Uytterhoeven
2016-08-29 15:52 ` Rob Herring
1 sibling, 2 replies; 7+ messages in thread
From: Yoshihiro Shimoda @ 2016-08-24 6:49 UTC (permalink / raw)
To: kishon, robh+dt, mark.rutland
Cc: linux-kernel, devicetree, linux-renesas-soc, Yoshihiro Shimoda
This driver can support for r8a7796 SoC. So, this patch adds it.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++
drivers/phy/phy-rcar-gen3-usb2.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
index b54fb36..ace9cce 100644
--- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
+++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
@@ -6,6 +6,8 @@ This file provides information on what the device node for the R-Car generation
Required properties:
- compatible: "renesas,usb2-phy-r8a7795" if the device is a part of an R8A7795
SoC.
+ "renesas,usb2-phy-r8a7796" if the device is a part of an R8A7796
+ SoC.
"renesas,rcar-gen3-usb2-phy" for a generic R-Car Gen3 compatible device.
When compatible with the generic version, nodes must list the
diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c
index 31156c9..3d97ead 100644
--- a/drivers/phy/phy-rcar-gen3-usb2.c
+++ b/drivers/phy/phy-rcar-gen3-usb2.c
@@ -280,6 +280,7 @@ static irqreturn_t rcar_gen3_phy_usb2_irq(int irq, void *_ch)
static const struct of_device_id rcar_gen3_phy_usb2_match_table[] = {
{ .compatible = "renesas,usb2-phy-r8a7795" },
+ { .compatible = "renesas,usb2-phy-r8a7796" },
{ .compatible = "renesas,rcar-gen3-usb2-phy" },
{ }
};
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] phy: rcar-gen3-usb2: Add a compatible string for r8a7796
2016-08-24 6:49 ` [PATCH 2/2] phy: rcar-gen3-usb2: Add a compatible string for r8a7796 Yoshihiro Shimoda
@ 2016-08-25 8:23 ` Geert Uytterhoeven
2016-08-29 15:52 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2016-08-25 8:23 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Kishon Vijay Abraham I, Rob Herring, Mark Rutland, linux-kernel,
devicetree, Linux-Renesas
On Wed, Aug 24, 2016 at 8:49 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> This driver can support for r8a7796 SoC. So, this patch adds it.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] phy: rcar-gen3-usb2: revise the example of device tree doc
2016-08-24 6:49 ` [PATCH 1/2] phy: rcar-gen3-usb2: revise the example of device tree doc Yoshihiro Shimoda
@ 2016-08-25 8:29 ` Geert Uytterhoeven
2016-08-29 15:51 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2016-08-25 8:29 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Kishon Vijay Abraham I, Rob Herring, Mark Rutland, linux-kernel,
devicetree, Linux-Renesas
Hi Shimoda-san,
On Wed, Aug 24, 2016 at 8:49 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> The clocks property should be set to &cpg, not &mstpX_clks.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> index 2281d6c..b54fb36 100644
> --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> @@ -30,11 +30,11 @@ Example (R-Car H3):
> compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
> reg = <0 0xee080200 0 0x700>;
> interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&mstp7_clks R8A7795_CLK_EHCI0>;
> + clocks = <&cpg CPG_MOD 703>;
> };
>
> usb-phy@ee0a0200 {
> compatible = "renesas,usb2-phy-r8a7795", "renesas,rcar-gen3-usb2-phy";
> reg = <0 0xee0a0200 0 0x700>;
> - clocks = <&mstp7_clks R8A7795_CLK_EHCI0>;
> + clocks = <&cpg CPG_MOD 702>;
> };
BTW, do you want to add #phy-cells and power-domains properties?
BTW2, the actual .dtsi doesn't have the "renesas,rcar-gen3-usb2-phy"
fallback properties.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] phy: rcar-gen3-usb2: revise the example of device tree doc
2016-08-24 6:49 ` [PATCH 1/2] phy: rcar-gen3-usb2: revise the example of device tree doc Yoshihiro Shimoda
2016-08-25 8:29 ` Geert Uytterhoeven
@ 2016-08-29 15:51 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2016-08-29 15:51 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: kishon, mark.rutland, linux-kernel, devicetree, linux-renesas-soc
On Wed, Aug 24, 2016 at 03:49:21PM +0900, Yoshihiro Shimoda wrote:
> The clocks property should be set to &cpg, not &mstpX_clks.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] phy: rcar-gen3-usb2: Add a compatible string for r8a7796
2016-08-24 6:49 ` [PATCH 2/2] phy: rcar-gen3-usb2: Add a compatible string for r8a7796 Yoshihiro Shimoda
2016-08-25 8:23 ` Geert Uytterhoeven
@ 2016-08-29 15:52 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2016-08-29 15:52 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: kishon, mark.rutland, linux-kernel, devicetree, linux-renesas-soc
On Wed, Aug 24, 2016 at 03:49:22PM +0900, Yoshihiro Shimoda wrote:
> This driver can support for r8a7796 SoC. So, this patch adds it.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++
> drivers/phy/phy-rcar-gen3-usb2.c | 1 +
> 2 files changed, 3 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-08-29 15:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-24 6:49 [PATCH 0/2] phy: rcar-gen3-usb2: revise the dt doc and add support for r8a7796 Yoshihiro Shimoda
2016-08-24 6:49 ` [PATCH 1/2] phy: rcar-gen3-usb2: revise the example of device tree doc Yoshihiro Shimoda
2016-08-25 8:29 ` Geert Uytterhoeven
2016-08-29 15:51 ` Rob Herring
2016-08-24 6:49 ` [PATCH 2/2] phy: rcar-gen3-usb2: Add a compatible string for r8a7796 Yoshihiro Shimoda
2016-08-25 8:23 ` Geert Uytterhoeven
2016-08-29 15:52 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).