* drm/atmel-hlcdc: connector type & fbdev mode settings
@ 2016-08-31 2:29 Hyung Jin Jung
2016-08-31 7:34 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Hyung Jin Jung @ 2016-08-31 2:29 UTC (permalink / raw)
To: boris.brezillon, airlied; +Cc: dri-devel, linux-kernel
According to Atmel's guideline... http://www.at91.com/linux4sam/bin/view/Linux4SAM/UsingAtmelDRMDriver
the "fbdev emulation mode" could be set from kernel command line (LVDS-1:...)
however, driver register it as DRM_MODE_CONNECTOR_Unknown connector.
Actually we using sama5d3x with LVDS cable so that below patch would be correct.
But I don't know the other case such as HDMI, composite...
Do we need to consider using DT or auto-detection??
Signed-off-by: HyungJin Jung <realbright@lgcns.com>
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
index 6119b50..da97efe
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
@@ -208,7 +208,7 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device *dev,
&atmel_hlcdc_panel_connector_helper_funcs);
ret = drm_connector_init(dev, &output->connector,
&atmel_hlcdc_panel_connector_funcs,
- DRM_MODE_CONNECTOR_Unknown);
+ DRM_MODE_CONNECTOR_LVDS);
if (ret)
goto err_encoder_cleanup;
--
1.9.1
BR,
Davy
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: drm/atmel-hlcdc: connector type & fbdev mode settings
2016-08-31 2:29 drm/atmel-hlcdc: connector type & fbdev mode settings Hyung Jin Jung
@ 2016-08-31 7:34 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2016-08-31 7:34 UTC (permalink / raw)
To: Hyung Jin Jung; +Cc: airlied, dri-devel, linux-kernel
On Wed, 31 Aug 2016 11:29:53 +0900
Hyung Jin Jung <realbright@lgcns.com> wrote:
> According to Atmel's guideline... http://www.at91.com/linux4sam/bin/view/Linux4SAM/UsingAtmelDRMDriver
>
> the "fbdev emulation mode" could be set from kernel command line (LVDS-1:...)
> however, driver register it as DRM_MODE_CONNECTOR_Unknown connector.
Just adapt the command line with Unknown-1:...
>
> Actually we using sama5d3x with LVDS cable so that below patch would be correct.
No it wouldn't. The sama5 SoC is providing a raw RGB interface, so if
you really have an LVDS interface on your board this means you have a
bridge in the middle. This bridge should be represented in the DT, and
attached to a driver in the kernel.
> But I don't know the other case such as HDMI, composite...
>
> Do we need to consider using DT or auto-detection??
>
> Signed-off-by: HyungJin Jung <realbright@lgcns.com>
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> index 6119b50..da97efe
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> @@ -208,7 +208,7 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device *dev,
> &atmel_hlcdc_panel_connector_helper_funcs);
> ret = drm_connector_init(dev, &output->connector,
> &atmel_hlcdc_panel_connector_funcs,
> - DRM_MODE_CONNECTOR_Unknown);
> + DRM_MODE_CONNECTOR_LVDS);
> if (ret)
> goto err_encoder_cleanup;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-31 7:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-31 2:29 drm/atmel-hlcdc: connector type & fbdev mode settings Hyung Jin Jung
2016-08-31 7:34 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).