From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: Mark Brown <broonie@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i
Date: Thu, 1 Sep 2016 18:45:01 +0200 [thread overview]
Message-ID: <20160901164501.GE20462@lukather> (raw)
In-Reply-To: <20160831221402.670ab832@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
Hi Danny,
On Wed, Aug 31, 2016 at 10:14:02PM +0200, Danny Milosavljevic wrote:
> Hi Maxime,
>
> On Wed, 31 Aug 2016 19:46:23 +0200
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>
> > > -#define SUN4I_CODEC_AC_SYS_VERI (0x38)
> > > -#define SUN4I_CODEC_AC_MIC_PHONE_CAL (0x3c)
> > > +
> > > +#define SUN7I_CODEC_AC_DAC_CAL (0x38)
> > > +#define SUN7I_CODEC_AC_MIC_PHONE_CAL (0x3c)
> >
> > That will need at least some mention in the commit log.
>
> Hm? It's now called like it is called in the user manual.
> Also, the macro SUN4I_CODEC_AC_SYS_VERI was unused before anyway.
>
> What should I write in the commit log?
For example, that the current code was wrong and those registers are
not present on the A10.
That way, you justify both the renaming, and the max_register change
in the regmap.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-01 16:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 5:44 [PATCH v9 0/2] sun4i-codec: Add Line-In, FM-In, Mic 2, Capture Source, Differential Line-In Danny Milosavljevic
2016-08-30 5:44 ` [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i Danny Milosavljevic
2016-08-31 3:22 ` Chen-Yu Tsai
2016-08-31 17:46 ` Maxime Ripard
2016-08-31 20:14 ` [linux-sunxi] " Danny Milosavljevic
2016-09-01 16:45 ` Maxime Ripard [this message]
2016-08-30 5:44 ` [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In Danny Milosavljevic
2016-08-31 6:24 ` Chen-Yu Tsai
2016-08-31 7:17 ` Danny Milosavljevic
2016-08-31 7:46 ` Chen-Yu Tsai
2016-08-31 7:40 ` [linux-sunxi] " Danny Milosavljevic
2016-08-31 7:43 ` Chen-Yu Tsai
2016-08-31 7:49 ` Danny Milosavljevic
2016-08-31 7:55 ` Chen-Yu Tsai
2016-09-01 10:56 ` Danny Milosavljevic
2016-09-01 13:25 ` [linux-sunxi] " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901164501.GE20462@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dannym@scratchpost.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).