linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] logfs: remove null check on block->alias_map as it is an array
@ 2016-09-06  7:56 Colin King
  0 siblings, 0 replies; only message in thread
From: Colin King @ 2016-09-06  7:56 UTC (permalink / raw)
  To: Joern Engel, Prasad Joshi, logfs; +Cc: linux-kernel

From: Colin Ian King <colin.king@canonical.com>

block->alias_map is an array of unsigned longs and so the null
check on block->alias_map is unneccessary, so remove it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fs/logfs/readwrite.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/logfs/readwrite.c b/fs/logfs/readwrite.c
index 3fb8c6d..9a7fea3 100644
--- a/fs/logfs/readwrite.c
+++ b/fs/logfs/readwrite.c
@@ -1279,9 +1279,8 @@ static void fill_shadow_tree(struct inode *inode, struct page *page,
 	struct shadow_tree *tree = &super->s_shadow_tree;
 
 	if (PagePrivate(page)) {
-		if (block->alias_map)
-			super->s_no_object_aliases -= bitmap_weight(
-					block->alias_map, LOGFS_BLOCK_FACTOR);
+		super->s_no_object_aliases -= bitmap_weight(
+			block->alias_map, LOGFS_BLOCK_FACTOR);
 		logfs_handle_transaction(inode, block->ta);
 		block->ops->free_block(inode->i_sb, block);
 	}
-- 
2.9.3

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-09-06  7:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-06  7:56 [PATCH] logfs: remove null check on block->alias_map as it is an array Colin King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).