[PATCH 00/10] ARM: dts: berlin: fix dtc warnings

[PATCH 00/10] ARM: dts: berlin: fix dtc warnings

[Jisheng Zhang]

This is a clean up series to fix berlin arm platforms dtc warnings.
Firstly we remove skeleton.dtsi inclusion. Then add missing unit name
of /soc node and /memory node. Lastly, we fix regulators' name

Jisheng Zhang (10):
  ARM: dts: berlin2q: Remove skeleton.dtsi inclusion
  ARM: dts: berlin2cd: Remove skeleton.dtsi inclusion
  ARM: dts: berlin2: Remove skeleton.dtsi inclusion
  ARM: dts: berlin2q: Add missing unit name to /soc node
  ARM: dts: berlin2cd: Add missing unit name to /soc node
  ARM: dts: berlin2: Add missing unit name to /soc node
  ARM: dts: berlin2q-marvell-dmp: add missing unit name to /memory node
  ARM: dts: chromecast: add missing unit name to /memory node
  ARM: dts: sony-nsz-gs7: add missing unit name to /memory node
  ARM: dts: berlin2q-marvell-dmp: fix regulators' name

 arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts        |  2 +-
 arch/arm/boot/dts/berlin2.dtsi                    |  5 +++--
 arch/arm/boot/dts/berlin2cd-google-chromecast.dts |  2 +-
 arch/arm/boot/dts/berlin2cd.dtsi                  |  5 +++--
 arch/arm/boot/dts/berlin2q-marvell-dmp.dts        | 12 ++++++------
 arch/arm/boot/dts/berlin2q.dtsi                   |  6 +++---
 6 files changed, 17 insertions(+), 15 deletions(-)

-- 
2.9.3

[PATCH 01/10] ARM: dts: berlin2q: Remove skeleton.dtsi inclusion

[Jisheng Zhang]

As noted in [1], "there are a number of problems with skeleton.dtsi,
and it would be prefereable to remove it entirely." This patch is to
remove skeleton.dtsi inclusion from berlin2q.

[1] http://www.spinics.net/lists/arm-kernel/msg528080.html

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/boot/dts/berlin2q.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 2c34bfb..4554945 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -37,11 +37,11 @@
 #include <dt-bindings/clock/berlin2q.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 
-#include "skeleton.dtsi"
-
 / {
 	model = "Marvell Armada 1500 pro (BG2-Q) SoC";
 	compatible = "marvell,berlin2q", "marvell,berlin";
+	#address-cells = <1>;
+	#size-cells = <1>;
 
 	aliases {
 		serial0 = &uart0;
-- 
2.9.3

[PATCH 02/10] ARM: dts: berlin2cd: Remove skeleton.dtsi inclusion

[Jisheng Zhang]

As noted in [1], "there are a number of problems with skeleton.dtsi,
and it would be prefereable to remove it entirely." This patch is to
remove skeleton.dtsi inclusion from berlin2cd.

[1] http://www.spinics.net/lists/arm-kernel/msg528080.html

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/boot/dts/berlin2cd.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/berlin2cd.dtsi b/arch/arm/boot/dts/berlin2cd.dtsi
index 6d06b61..d2bf390 100644
--- a/arch/arm/boot/dts/berlin2cd.dtsi
+++ b/arch/arm/boot/dts/berlin2cd.dtsi
@@ -39,13 +39,14 @@
  *     OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "skeleton.dtsi"
 #include <dt-bindings/clock/berlin2.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 
 / {
 	model = "Marvell Armada 1500-mini (BG2CD) SoC";
 	compatible = "marvell,berlin2cd", "marvell,berlin";
+	#address-cells = <1>;
+	#size-cells = <1>;
 
 	aliases {
 		serial0 = &uart0;
-- 
2.9.3

[PATCH 03/10] ARM: dts: berlin2: Remove skeleton.dtsi inclusion

[Jisheng Zhang]

As noted in [1], "there are a number of problems with skeleton.dtsi,
and it would be prefereable to remove it entirely." This patch is to
remove skeleton.dtsi inclusion from berlin2.

[1] http://www.spinics.net/lists/arm-kernel/msg528080.html

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/boot/dts/berlin2.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi
index ae81009..c89a441 100644
--- a/arch/arm/boot/dts/berlin2.dtsi
+++ b/arch/arm/boot/dts/berlin2.dtsi
@@ -39,13 +39,14 @@
  *     OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "skeleton.dtsi"
 #include <dt-bindings/clock/berlin2.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 
 / {
 	model = "Marvell Armada 1500 (BG2) SoC";
 	compatible = "marvell,berlin2", "marvell,berlin";
+	#address-cells = <1>;
+	#size-cells = <1>;
 
 	aliases {
 		serial0 = &uart0;
-- 
2.9.3

[PATCH 04/10] ARM: dts: berlin2q: Add missing unit name to /soc node

[Jisheng Zhang]

This patch fixes the following DTC warning with W=1:

"Node /soc has a reg or ranges property, but no unit name"

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/boot/dts/berlin2q.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 4554945..6bd92ffd 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -99,7 +99,7 @@
 		clock-frequency = <25000000>;
 	};
 
-	soc {
+	soc@f7000000 {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.9.3

[PATCH 05/10] ARM: dts: berlin2cd: Add missing unit name to /soc node

[Jisheng Zhang]

This patch fixes the following DTC warning with W=1:

"Node /soc has a reg or ranges property, but no unit name"

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/boot/dts/berlin2cd.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/berlin2cd.dtsi b/arch/arm/boot/dts/berlin2cd.dtsi
index d2bf390..4fe1574 100644
--- a/arch/arm/boot/dts/berlin2cd.dtsi
+++ b/arch/arm/boot/dts/berlin2cd.dtsi
@@ -79,7 +79,7 @@
 		clock-frequency = <25000000>;
 	};
 
-	soc {
+	soc@f7000000 {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.9.3

[PATCH 06/10] ARM: dts: berlin2: Add missing unit name to /soc node

[Jisheng Zhang]

This patch fixes the following DTC warning with W=1:

"Node /soc has a reg or ranges property, but no unit name"

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/boot/dts/berlin2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi
index c89a441..e5a1a32 100644
--- a/arch/arm/boot/dts/berlin2.dtsi
+++ b/arch/arm/boot/dts/berlin2.dtsi
@@ -90,7 +90,7 @@
 		clock-frequency = <25000000>;
 	};
 
-	soc {
+	soc@f7000000 {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.9.3

[PATCH 07/10] ARM: dts: berlin2q-marvell-dmp: add missing unit name to /memory node

[Jisheng Zhang]

This patch fixes the following DTC warning with W=1:

"Node /memory has a reg or ranges property, but no unit name"

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
index 33b2875..f485308 100644
--- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
+++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
@@ -43,7 +43,7 @@
 	model = "Marvell BG2-Q DMP";
 	compatible = "marvell,berlin2q-dmp", "marvell,berlin2q", "marvell,berlin";
 
-	memory {
+	memory@0 {
 		device_type = "memory";
 		reg = <0x00000000 0x80000000>;
 	};
-- 
2.9.3

[PATCH 08/10] ARM: dts: chromecast: add missing unit name to /memory node

[Jisheng Zhang]

This patch fixes the following DTC warning with W=1:

"Node /memory has a reg or ranges property, but no unit name"

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
index 8ba8b50..ca24def 100644
--- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
+++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
@@ -50,7 +50,7 @@
 		stdout-path = "serial0:115200n8";
 	};
 
-	memory {
+	memory@0 {
 		device_type = "memory";
 		reg = <0x00000000 0x20000000>; /* 512 MB */
 	};
-- 
2.9.3

Re: [PATCH 00/10] ARM: dts: berlin: fix dtc warnings

[Sebastian Hesselbarth]

On 06.09.2016 10:40, Jisheng Zhang wrote:
> This is a clean up series to fix berlin arm platforms dtc warnings.
> Firstly we remove skeleton.dtsi inclusion. Then add missing unit name
> of /soc node and /memory node. Lastly, we fix regulators' name
>
> Jisheng Zhang (10):
>    ARM: dts: berlin2q: Remove skeleton.dtsi inclusion
>    ARM: dts: berlin2cd: Remove skeleton.dtsi inclusion
>    ARM: dts: berlin2: Remove skeleton.dtsi inclusion
>    ARM: dts: berlin2q: Add missing unit name to /soc node
>    ARM: dts: berlin2cd: Add missing unit name to /soc node
>    ARM: dts: berlin2: Add missing unit name to /soc node
>    ARM: dts: berlin2q-marvell-dmp: add missing unit name to /memory node
>    ARM: dts: chromecast: add missing unit name to /memory node

Jisheng,

Applied the 8 patches above.

>    ARM: dts: sony-nsz-gs7: add missing unit name to /memory node

I didn't receive this one and could not find it online.
I recreated the patch by using the chromecast patch above, so
applied.

>    ARM: dts: berlin2q-marvell-dmp: fix regulators' name

I have no clue what it should be fixed to.

Sebastian

>   arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts        |  2 +-
>   arch/arm/boot/dts/berlin2.dtsi                    |  5 +++--
>   arch/arm/boot/dts/berlin2cd-google-chromecast.dts |  2 +-
>   arch/arm/boot/dts/berlin2cd.dtsi                  |  5 +++--
>   arch/arm/boot/dts/berlin2q-marvell-dmp.dts        | 12 ++++++------
>   arch/arm/boot/dts/berlin2q.dtsi                   |  6 +++---
>   6 files changed, 17 insertions(+), 15 deletions(-)
>

Re: [PATCH 00/10] ARM: dts: berlin: fix dtc warnings

[Jisheng Zhang]

Hi Sebastian,

On Wed, 28 Sep 2016 21:40:21 +0200 Sebastian Hesselbarth wrote:

> On 06.09.2016 10:40, Jisheng Zhang wrote:
> > This is a clean up series to fix berlin arm platforms dtc warnings.
> > Firstly we remove skeleton.dtsi inclusion. Then add missing unit name
> > of /soc node and /memory node. Lastly, we fix regulators' name
> >
> > Jisheng Zhang (10):
> >    ARM: dts: berlin2q: Remove skeleton.dtsi inclusion
> >    ARM: dts: berlin2cd: Remove skeleton.dtsi inclusion
> >    ARM: dts: berlin2: Remove skeleton.dtsi inclusion
> >    ARM: dts: berlin2q: Add missing unit name to /soc node
> >    ARM: dts: berlin2cd: Add missing unit name to /soc node
> >    ARM: dts: berlin2: Add missing unit name to /soc node
> >    ARM: dts: berlin2q-marvell-dmp: add missing unit name to /memory node
> >    ARM: dts: chromecast: add missing unit name to /memory node  
> 
> Jisheng,
> 
> Applied the 8 patches above.
> 
> >    ARM: dts: sony-nsz-gs7: add missing unit name to /memory node  
> 
> I didn't receive this one and could not find it online.
> I recreated the patch by using the chromecast patch above, so
> applied.
> 
> >    ARM: dts: berlin2q-marvell-dmp: fix regulators' name  
> 
> I have no clue what it should be fixed to.

DTC will complain with W=1:

Warning (unit_address_vs_reg): Node /regulators/regulator@0 has a unit
name, but no reg property

This patch tries to fix that warning.

Thanks,
Jisheng

> 
> Sebastian
> 
> >   arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts        |  2 +-
> >   arch/arm/boot/dts/berlin2.dtsi                    |  5 +++--
> >   arch/arm/boot/dts/berlin2cd-google-chromecast.dts |  2 +-
> >   arch/arm/boot/dts/berlin2cd.dtsi                  |  5 +++--
> >   arch/arm/boot/dts/berlin2q-marvell-dmp.dts        | 12 ++++++------
> >   arch/arm/boot/dts/berlin2q.dtsi                   |  6 +++---
> >   6 files changed, 17 insertions(+), 15 deletions(-)
> >  
>