* [PATCH] s390/crypto: initialize ret to zero to avoid returning garbage value
@ 2016-09-05 16:21 Colin King
2016-09-06 7:10 ` Martin Schwidefsky
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-09-05 16:21 UTC (permalink / raw)
To: Herbert Xu, David S . Miller, Martin Schwidefsky, Heiko Carstens,
linux-crypto, linux-s390
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
static analysis with cppcheck detected that ret is not initialized
and hence garbage is potentially being returned in the case where
prng_data->ppnows.reseed_counter <= prng_reseed_limit.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/s390/crypto/prng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/crypto/prng.c b/arch/s390/crypto/prng.c
index 79e3a1f..a21fdf4 100644
--- a/arch/s390/crypto/prng.c
+++ b/arch/s390/crypto/prng.c
@@ -412,7 +412,7 @@ static int prng_sha512_reseed(void)
static int prng_sha512_generate(u8 *buf, size_t nbytes)
{
- int ret;
+ int ret = 0;
/* reseed needed ? */
if (prng_data->ppnows.reseed_counter > prng_reseed_limit) {
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390/crypto: initialize ret to zero to avoid returning garbage value
2016-09-05 16:21 [PATCH] s390/crypto: initialize ret to zero to avoid returning garbage value Colin King
@ 2016-09-06 7:10 ` Martin Schwidefsky
0 siblings, 0 replies; 2+ messages in thread
From: Martin Schwidefsky @ 2016-09-06 7:10 UTC (permalink / raw)
To: Colin King
Cc: Herbert Xu, David S . Miller, Heiko Carstens, linux-crypto,
linux-s390, linux-kernel
On Mon, 5 Sep 2016 17:21:18 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> static analysis with cppcheck detected that ret is not initialized
> and hence garbage is potentially being returned in the case where
> prng_data->ppnows.reseed_counter <= prng_reseed_limit.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/s390/crypto/prng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/crypto/prng.c b/arch/s390/crypto/prng.c
> index 79e3a1f..a21fdf4 100644
> --- a/arch/s390/crypto/prng.c
> +++ b/arch/s390/crypto/prng.c
> @@ -412,7 +412,7 @@ static int prng_sha512_reseed(void)
>
> static int prng_sha512_generate(u8 *buf, size_t nbytes)
> {
> - int ret;
> + int ret = 0;
>
> /* reseed needed ? */
> if (prng_data->ppnows.reseed_counter > prng_reseed_limit) {
This issue has been introduced by git commit 0177db01adf26cf9
"s390/crypto: simplify return code handling" which is only on
the features branch right now. And to set ret=0 does not fix
the problem. The correct fix is to return nbytes.
Still a good catch though.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-06 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-05 16:21 [PATCH] s390/crypto: initialize ret to zero to avoid returning garbage value Colin King
2016-09-06 7:10 ` Martin Schwidefsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).