* [PATCH] staging: dgnc: Fix multi line comment alignment
@ 2016-09-05 18:28 Fernando Apesteguia
2016-09-05 20:45 ` Andrey Utkin
0 siblings, 1 reply; 4+ messages in thread
From: Fernando Apesteguia @ 2016-09-05 18:28 UTC (permalink / raw)
To: lidza.louina; +Cc: markh, gregkh, driverdev-devel, devel, linux-kernel
Fix alignment in multi line comment block.
Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle
Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.c | 50 +++++++++++++++++++-------------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
index cc6105a..01e948c 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
brd->re_map_membase = ioremap(brd->membase, 0x1000);
}
-/*****************************************************************************
-*
-* Function:
-*
-* dgnc_poll_handler
-*
-* Author:
-*
-* Scott H Kilau
-*
-* Parameters:
-*
-* dummy -- ignored
-*
-* Return Values:
-*
-* none
-*
-* Description:
-*
-* As each timer expires, it determines (a) whether the "transmit"
-* waiter needs to be woken up, and (b) whether the poller needs to
-* be rescheduled.
-*
-******************************************************************************/
+/*
+ *
+ * Function:
+ *
+ * dgnc_poll_handler
+ *
+ * Author:
+ *
+ * Scott H Kilau
+ *
+ * Parameters:
+ *
+ * dummy -- ignored
+ *
+ * Return Values:
+ *
+ * none
+ *
+ * Description:
+ *
+ * As each timer expires, it determines (a) whether the "transmit"
+ * waiter needs to be woken up, and (b) whether the poller needs to
+ * be rescheduled.
+ *
+ */
static void dgnc_poll_handler(ulong dummy)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: dgnc: Fix multi line comment alignment
2016-09-05 18:28 [PATCH] staging: dgnc: Fix multi line comment alignment Fernando Apesteguia
@ 2016-09-05 20:45 ` Andrey Utkin
2016-09-06 13:19 ` Fernando Apesteguia
0 siblings, 1 reply; 4+ messages in thread
From: Andrey Utkin @ 2016-09-05 20:45 UTC (permalink / raw)
To: Fernando Apesteguia
Cc: lidza.louina, gregkh, driverdev-devel, linux-kernel, devel
On Mon, Sep 05, 2016 at 08:28:32PM +0200, Fernando Apesteguia wrote:
> Fix alignment in multi line comment block.
>
> Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle
>
> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
>
> ---
> drivers/staging/dgnc/dgnc_driver.c | 50 +++++++++++++++++++-------------------
> 1 file changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index cc6105a..01e948c 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
> brd->re_map_membase = ioremap(brd->membase, 0x1000);
> }
>
> -/*****************************************************************************
> -*
> -* Function:
> -*
> -* dgnc_poll_handler
> -*
> -* Author:
> -*
> -* Scott H Kilau
> -*
> -* Parameters:
> -*
> -* dummy -- ignored
> -*
> -* Return Values:
> -*
> -* none
> -*
> -* Description:
> -*
> -* As each timer expires, it determines (a) whether the "transmit"
> -* waiter needs to be woken up, and (b) whether the poller needs to
> -* be rescheduled.
> -*
> -******************************************************************************/
> +/*
> + *
> + * Function:
> + *
> + * dgnc_poll_handler
> + *
> + * Author:
> + *
> + * Scott H Kilau
> + *
> + * Parameters:
> + *
> + * dummy -- ignored
> + *
> + * Return Values:
> + *
> + * none
> + *
> + * Description:
> + *
> + * As each timer expires, it determines (a) whether the "transmit"
> + * waiter needs to be woken up, and (b) whether the poller needs to
> + * be rescheduled.
> + *
> + */
>
> static void dgnc_poll_handler(ulong dummy)
> {
> --
> 2.7.4
Changing first and last lines of that comment should be enough, but all
lines got changed. I'd (re)submit it with just first and last lines
changed.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: dgnc: Fix multi line comment alignment
2016-09-05 20:45 ` Andrey Utkin
@ 2016-09-06 13:19 ` Fernando Apesteguia
2016-09-06 14:49 ` Andrey Utkin
0 siblings, 1 reply; 4+ messages in thread
From: Fernando Apesteguia @ 2016-09-06 13:19 UTC (permalink / raw)
To: Andrey Utkin; +Cc: lidza.louina, gregkh, driverdev-devel, linux-kernel, devel
On Mon, Sep 05, 2016 at 11:45:30PM +0300, Andrey Utkin wrote:
> On Mon, Sep 05, 2016 at 08:28:32PM +0200, Fernando Apesteguia wrote:
> > Fix alignment in multi line comment block.
> >
> > Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle
> >
> > Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
> >
> > ---
> > drivers/staging/dgnc/dgnc_driver.c | 50 +++++++++++++++++++-------------------
> > 1 file changed, 25 insertions(+), 25 deletions(-)
> >
> > diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> > index cc6105a..01e948c 100644
> > --- a/drivers/staging/dgnc/dgnc_driver.c
> > +++ b/drivers/staging/dgnc/dgnc_driver.c
> > @@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
> > brd->re_map_membase = ioremap(brd->membase, 0x1000);
> > }
> >
> > -/*****************************************************************************
> > -*
> > -* Function:
> > -*
> > -* dgnc_poll_handler
> > -*
> > -* Author:
> > -*
> > -* Scott H Kilau
> > -*
> > -* Parameters:
> > -*
> > -* dummy -- ignored
> > -*
> > -* Return Values:
> > -*
> > -* none
> > -*
> > -* Description:
> > -*
> > -* As each timer expires, it determines (a) whether the "transmit"
> > -* waiter needs to be woken up, and (b) whether the poller needs to
> > -* be rescheduled.
> > -*
> > -******************************************************************************/
> > +/*
> > + *
> > + * Function:
> > + *
> > + * dgnc_poll_handler
> > + *
> > + * Author:
> > + *
> > + * Scott H Kilau
> > + *
> > + * Parameters:
> > + *
> > + * dummy -- ignored
> > + *
> > + * Return Values:
> > + *
> > + * none
> > + *
> > + * Description:
> > + *
> > + * As each timer expires, it determines (a) whether the "transmit"
> > + * waiter needs to be woken up, and (b) whether the poller needs to
> > + * be rescheduled.
> > + *
> > + */
> >
> > static void dgnc_poll_handler(ulong dummy)
> > {
> > --
> > 2.7.4
>
> Changing first and last lines of that comment should be enough, but all
> lines got changed. I'd (re)submit it with just first and last lines
> changed.
Sorry, but I fail to see how I can align all the lines by changing just the first and last ones.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: dgnc: Fix multi line comment alignment
2016-09-06 13:19 ` Fernando Apesteguia
@ 2016-09-06 14:49 ` Andrey Utkin
0 siblings, 0 replies; 4+ messages in thread
From: Andrey Utkin @ 2016-09-06 14:49 UTC (permalink / raw)
To: Fernando Apesteguia
Cc: lidza.louina, gregkh, driverdev-devel, linux-kernel, devel
On Tue, Sep 06, 2016 at 03:19:03PM +0200, Fernando Apesteguia wrote:
> Sorry, but I fail to see how I can align all the lines by changing just the first and last ones.
Ah now I see that original version doesn't have spaces before asterisk.
Sorry for noise.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-06 14:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-05 18:28 [PATCH] staging: dgnc: Fix multi line comment alignment Fernando Apesteguia
2016-09-05 20:45 ` Andrey Utkin
2016-09-06 13:19 ` Fernando Apesteguia
2016-09-06 14:49 ` Andrey Utkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).