[PATCH] drm/atmel-hlcdc: mark atmel_hlcdc_crtc_reset() static

[PATCH] drm/atmel-hlcdc: mark atmel_hlcdc_crtc_reset() static

[Baoyou Xie]

We get 1 warning when building kernel with W=1:
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c:390:6: warning: no previous prototype for 'atmel_hlcdc_crtc_reset' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
index a978381..9b17a66 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
@@ -387,7 +387,7 @@ void atmel_hlcdc_crtc_irq(struct drm_crtc *c)
 	atmel_hlcdc_crtc_finish_page_flip(drm_crtc_to_atmel_hlcdc_crtc(c));
 }
 
-void atmel_hlcdc_crtc_reset(struct drm_crtc *crtc)
+static void atmel_hlcdc_crtc_reset(struct drm_crtc *crtc)
 {
 	struct atmel_hlcdc_crtc_state *state;
 
-- 
2.7.4

Re: [PATCH] drm/atmel-hlcdc: mark atmel_hlcdc_crtc_reset() static

[Arnd Bergmann]

On Tuesday, September 6, 2016 3:46:16 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c:390:6: warning: no previous prototype for 'atmel_hlcdc_crtc_reset' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

Re: [PATCH] drm/atmel-hlcdc: mark atmel_hlcdc_crtc_reset() static

[Boris Brezillon]

On Tue, 06 Sep 2016 15:43:45 +0200
Arnd Bergmann <arnd@arndb.de> wrote:

> On Tuesday, September 6, 2016 3:46:16 PM CEST Baoyou Xie wrote:
> > We get 1 warning when building kernel with W=1:
> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c:390:6: warning: no previous prototype for 'atmel_hlcdc_crtc_reset' [-Wmissing-prototypes]
> > 
> > In fact, this function is only used in the file in which it is
> > declared and don't need a declaration, but can be made static.
> > So this patch marks it 'static'.
> > 
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> >   
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Actually, Thierry already posted the same patch a while ago. I just
sent a PR to Dave containing this patch.