linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c)
Date: Wed, 7 Sep 2016 12:44:22 -0400	[thread overview]
Message-ID: <20160907124422.70216727@gandalf.local.home> (raw)
In-Reply-To: <d6c3b7eb-ba95-1ffa-0453-464e1e24262a@infradead.org>

On Wed, 7 Sep 2016 09:37:00 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:

> On 09/07/16 00:52, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20160906:
> >   
> 
> on i386:
> 
> ../kernel/trace/trace_hwlat.c: In function 'get_sample':
> ../kernel/trace/trace_hwlat.c:258:18: error: 'struct trace_array' has no member named 'max_latency'
>    if (sample > tr->max_latency)
>                   ^
> ../kernel/trace/trace_hwlat.c:259:6: error: 'struct trace_array' has no member named 'max_latency'
>     tr->max_latency = sample;
>       ^
> ../kernel/trace/trace_hwlat.c: In function 'hwlat_tracer_init':
> ../kernel/trace/trace_hwlat.c:583:4: error: 'struct trace_array' has no member named 'max_latency'
>   tr->max_latency = 0;
>     ^
> 
> when CONFIG_TRACER_MAX_TRACE is not enabled.
> 

Thanks!

Below is the fix. I'll have to add it.

-- Steve


diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 72c07c2ffd79..d9000a81960e 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -224,6 +224,7 @@ config SCHED_TRACER
 config HWLAT_TRACER
 	bool "Tracer to detect hardware latencies (like SMIs)"
 	select GENERIC_TRACER
+	select TRACER_MAX_TRACE
 	help
 	 This tracer, when enabled will create one or more kernel threads,
 	 depening on what the cpumask file is set to, which each thread

  reply	other threads:[~2016-09-07 16:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07  7:52 linux-next: Tree for Sep 7 Stephen Rothwell
2016-09-07 16:37 ` linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) Randy Dunlap
2016-09-07 16:44   ` Steven Rostedt [this message]
2016-09-07 18:34     ` Randy Dunlap
2016-09-07 18:48       ` Steven Rostedt
2016-09-07 19:38         ` Steven Rostedt
2016-09-07 20:55           ` Randy Dunlap
2016-09-08  2:58             ` Steven Rostedt
2016-09-08  5:38               ` Randy Dunlap
2016-09-07 21:42           ` Stephen Rothwell
2016-09-08  2:59             ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160907124422.70216727@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).