From: Randy Dunlap <rdunlap@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c)
Date: Wed, 7 Sep 2016 13:55:47 -0700 [thread overview]
Message-ID: <4b599d6d-ae48-8833-cb17-a7aa1fe1c41f@infradead.org> (raw)
In-Reply-To: <20160907153810.54f2a9ef@gandalf.local.home>
On 09/07/16 12:38, Steven Rostedt wrote:
> On Wed, 7 Sep 2016 14:48:38 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> Will send another one soon.
>
> What about this?
>
> -- Steve
>
> commit 64cfdb9788bf3fb2bf6c30701fc3644f25e76df2
> Author: Steven Rostedt (Red Hat) <rostedt@goodmis.org>
> Date: Wed Sep 7 12:45:09 2016 -0400
>
> tracing: Have max_latency be defined for HWLAT_TRACER as well
>
> The hwlat tracer uses tr->max_latency, and if it's the only tracer enabled
> that uses it, the build will fail. Add max_latency and its file when the
> hwlat tracer is enabled.
>
> Link: http://lkml.kernel.org/r/20160907175258.1f17a8ba@canb.auug.org.au
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 474cc814e16d..e0d0cfc1aa20 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -4945,7 +4945,7 @@ out:
> return ret;
> }
>
> -#ifdef CONFIG_TRACER_MAX_TRACE
> +#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)
>
> static ssize_t
> tracing_max_lat_read(struct file *filp, char __user *ubuf,
> @@ -5867,7 +5867,7 @@ static const struct file_operations tracing_thresh_fops = {
> .llseek = generic_file_llseek,
> };
>
> -#ifdef CONFIG_TRACER_MAX_TRACE
> +#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)
> static const struct file_operations tracing_max_lat_fops = {
> .open = tracing_open_generic,
> .read = tracing_max_lat_read,
> @@ -7195,7 +7195,7 @@ init_tracer_tracefs(struct trace_array *tr, struct dentry *d_tracer)
>
> create_trace_options_dir(tr);
>
> -#ifdef CONFIG_TRACER_MAX_TRACE
> +#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)
> trace_create_file("tracing_max_latency", 0644, d_tracer,
> &tr->max_latency, &tracing_max_lat_fops);
> #endif
> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> index 1d866b0c1567..fd24b1f9ac43 100644
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -214,6 +214,8 @@ struct trace_array {
> */
> struct trace_buffer max_buffer;
> bool allocated_snapshot;
> +#endif
> +#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)
> unsigned long max_latency;
> #endif
> struct trace_pid_list __rcu *filtered_pids;
> --
Yes, that works. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
next prev parent reply other threads:[~2016-09-07 20:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 7:52 linux-next: Tree for Sep 7 Stephen Rothwell
2016-09-07 16:37 ` linux-next: Tree for Sep 7 (kernel/trace/trace_hwlat.c) Randy Dunlap
2016-09-07 16:44 ` Steven Rostedt
2016-09-07 18:34 ` Randy Dunlap
2016-09-07 18:48 ` Steven Rostedt
2016-09-07 19:38 ` Steven Rostedt
2016-09-07 20:55 ` Randy Dunlap [this message]
2016-09-08 2:58 ` Steven Rostedt
2016-09-08 5:38 ` Randy Dunlap
2016-09-07 21:42 ` Stephen Rothwell
2016-09-08 2:59 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b599d6d-ae48-8833-cb17-a7aa1fe1c41f@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).