From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
Daniel Wagner <wagi@monom.org>,
linux-kernel@vger.kernel.org, Ming Lei <ming.lei@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH v4 1/4] firmware: Move umh locking code into fw_load_from_user_helper()
Date: Thu, 8 Sep 2016 16:55:41 +0200 [thread overview]
Message-ID: <20160908145541.GF3296@wotan.suse.de> (raw)
In-Reply-To: <509a727e-e784-8e6f-c112-760a0f8493b6@bmw-carit.de>
On Thu, Sep 08, 2016 at 02:41:33PM +0200, Daniel Wagner wrote:
> So far I have it tested with kvm. I'll give it a spin on real
> hardware. Good point.
If you can also include testing with the test_firmware.ko driver
and describe your tests in the cover letter that would be appreciated.
Bonus points if you also indicate you've had 0-day have full success
with your delta. To do that just poke Fenguang that you need testing
for a branch, and then push to your branch. I noted I gave your changes
a test spin and it came back OK, so it should be good, but still, this
is rather good practice for any changes sent out.
Luis
next prev parent reply other threads:[~2016-09-08 14:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 8:45 [PATCH v4 0/4] firmware: encapsulate firmware loading status Daniel Wagner
2016-09-07 8:45 ` [PATCH v4 1/4] firmware: Move umh locking code into fw_load_from_user_helper() Daniel Wagner
2016-09-07 23:33 ` Luis R. Rodriguez
2016-09-08 12:41 ` Daniel Wagner
2016-09-08 14:55 ` Luis R. Rodriguez [this message]
2016-09-08 15:37 ` Ming Lei
2016-09-08 20:11 ` Luis R. Rodriguez
2016-09-09 1:22 ` Ming Lei
[not found] ` <CAB=NE6XK9g9muQ8p5+VaVGt2t0E_4K0wiavacQGqt_S4PyN28A@mail.gmail.com>
2016-09-09 4:19 ` Ming Lei
2016-09-09 22:10 ` Luis R. Rodriguez
[not found] ` <efba9730-d3bc-1fd4-2511-e509a4c60971@bmw-carit.de>
2016-09-15 15:43 ` Luis R. Rodriguez
2016-09-07 8:45 ` [PATCH v4 2/4] firmware: encapsulate firmware loading status Daniel Wagner
2016-09-08 1:39 ` Luis R. Rodriguez
2016-09-08 8:05 ` Daniel Wagner
2016-09-08 9:45 ` Daniel Wagner
2016-09-08 11:26 ` Ming Lei
2016-09-08 12:26 ` Daniel Wagner
2016-09-08 15:49 ` Ming Lei
2016-09-09 11:43 ` Daniel Wagner
2016-09-08 12:32 ` Daniel Wagner
2016-09-07 8:45 ` [PATCH v4 3/4] firmware: Drop bit ops in favor of simple state machine Daniel Wagner
2016-09-08 1:45 ` Luis R. Rodriguez
2016-09-08 12:44 ` Daniel Wagner
2016-09-07 8:45 ` [PATCH v4 4/4] firmware: Do not use fw_lock for fw_status protection Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908145541.GF3296@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=rjw@sisk.pl \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).