From: Daniel Wagner <daniel.wagner@bmw-carit.de>
To: Ming Lei <ming.lei@canonical.com>, Daniel Wagner <wagi@monom.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v4 2/4] firmware: encapsulate firmware loading status
Date: Fri, 9 Sep 2016 13:43:45 +0200 [thread overview]
Message-ID: <21db8fb6-8d9e-0ff9-5623-cbbb01b72355@bmw-carit.de> (raw)
In-Reply-To: <CACVXFVPS1_kSdFyc2XnBxW5uk34SP-=BHLRHBHSLK+z78jdkdg@mail.gmail.com>
On 09/08/2016 05:49 PM, Ming Lei wrote:
> On Thu, Sep 8, 2016 at 8:26 PM, Daniel Wagner <wagi@monom.org> wrote:
>>
>> if (ret != 0 && test_bit(...))
>> return -ENOENT;
>
> Another question, why do you want to return -ENOENT when
> userspace aborts the load? And looks it will always be override as
> -EAGAIN.
I took the -ENOENT from sync_cached_firmware_buf():
/* wait until the shared firmware_buf becomes ready (or error) */
static int sync_cached_firmware_buf(struct firmware_buf *buf)
{
int ret = 0;
mutex_lock(&fw_lock);
- while (!test_bit(FW_STATUS_DONE, &buf->status)) {
- if (is_fw_load_aborted(buf)) {
+ while (!fw_status_is_done(&buf->fw_st)) {
+ if (fw_status_is_aborted(&buf->fw_st)) {
ret = -ENOENT;
break;
}
mutex_unlock(&fw_lock);
- ret = wait_for_completion_interruptible(&buf->completion);
+ ret = fw_status_wait_timeout(&buf->fw_st, 0);
mutex_lock(&fw_lock);
There is a path where it not overwritten by -EAGAIN:
request_firmware()
_request_firmware()
_request_firmware_prepare
sync_cached_firmware_buf()
fw_status_wait_timeout()
return -ENOENT
If you want me to change it to EAGAIN, I'll do it. I just tried hard not
to have any changes in behavior.
cheer,
daniel
next prev parent reply other threads:[~2016-09-09 11:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 8:45 [PATCH v4 0/4] firmware: encapsulate firmware loading status Daniel Wagner
2016-09-07 8:45 ` [PATCH v4 1/4] firmware: Move umh locking code into fw_load_from_user_helper() Daniel Wagner
2016-09-07 23:33 ` Luis R. Rodriguez
2016-09-08 12:41 ` Daniel Wagner
2016-09-08 14:55 ` Luis R. Rodriguez
2016-09-08 15:37 ` Ming Lei
2016-09-08 20:11 ` Luis R. Rodriguez
2016-09-09 1:22 ` Ming Lei
[not found] ` <CAB=NE6XK9g9muQ8p5+VaVGt2t0E_4K0wiavacQGqt_S4PyN28A@mail.gmail.com>
2016-09-09 4:19 ` Ming Lei
2016-09-09 22:10 ` Luis R. Rodriguez
[not found] ` <efba9730-d3bc-1fd4-2511-e509a4c60971@bmw-carit.de>
2016-09-15 15:43 ` Luis R. Rodriguez
2016-09-07 8:45 ` [PATCH v4 2/4] firmware: encapsulate firmware loading status Daniel Wagner
2016-09-08 1:39 ` Luis R. Rodriguez
2016-09-08 8:05 ` Daniel Wagner
2016-09-08 9:45 ` Daniel Wagner
2016-09-08 11:26 ` Ming Lei
2016-09-08 12:26 ` Daniel Wagner
2016-09-08 15:49 ` Ming Lei
2016-09-09 11:43 ` Daniel Wagner [this message]
2016-09-08 12:32 ` Daniel Wagner
2016-09-07 8:45 ` [PATCH v4 3/4] firmware: Drop bit ops in favor of simple state machine Daniel Wagner
2016-09-08 1:45 ` Luis R. Rodriguez
2016-09-08 12:44 ` Daniel Wagner
2016-09-07 8:45 ` [PATCH v4 4/4] firmware: Do not use fw_lock for fw_status protection Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21db8fb6-8d9e-0ff9-5623-cbbb01b72355@bmw-carit.de \
--to=daniel.wagner@bmw-carit.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ming.lei@canonical.com \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).