From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [v2] musb: omap2430: do not assume balanced enable()/disable()
Date: Fri, 9 Sep 2016 14:33:42 -0700 [thread overview]
Message-ID: <20160909213341.m2tmrvws5ffomnho@atomide.com> (raw)
In-Reply-To: <20160909232206.70ee2558@aktux>
* Andreas Kemnade <andreas@kemnade.info> [160909 14:22]:
> On Fri, 9 Sep 2016 13:51:04 -0700
> Tony Lindgren <tony@atomide.com> wrote:
> > Well for the phy-twl4030-usb.c, AFAIK the right fix is to fix the PHY
> > driver as done in "[PATCH v2] phy-twl4030-usb: initialize
> > charging-related stuff via pm_runtime". I suspect something similar
> > is happening here also with the omap4 legacy phy.
> >
> No, the fix is for making charging work independant of musb.
> Gadget is working because charging is enabled and enables all parts in
> the phy needed for it. And you can charge without musb (only musb_hdrc
> for the mailbox but not the omap2430 glue module).
Oh right.
> We have two independant things:
> 1. phy-twl4030-usb (and perhaps others) do not enable
> the phy enough to allow charging on pm_runtime_get().
> That is fixed by my phy-related patches.
OK
> 2. phy_power_off/on() in called in an unbalanced way if
> it is called behind musb_platform_enable()/disable()
> as it happens in omap2430.c. Two ways to fix it:
> a) prevent phy_power_off()/on() to be called in
> an unbalanced way in omap240.c
> b) prevent musb_platform_enable()
> musb_platform_disable() to be called in an
> unbalanced way by fixing musb_core.c
>
> Fixing 1. is enough on gta04 to fix charging and hide 2. enough to
> have gadget working for the most common usecases. (not using
> twl4030-charger would not work yet)
> But in the longer term 2. has to be fixed too.
Sounds like option 2b here is the real fix.
Regards,
Tony
next prev parent reply other threads:[~2016-09-09 21:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 15:38 [PATCH v2] musb: omap2430: do not assume balanced enable()/disable() Andreas Kemnade
2016-08-03 17:07 ` [Letux-kernel] " H. Nikolaus Schaller
2016-08-04 14:29 ` Tony Lindgren
2016-08-04 14:49 ` H. Nikolaus Schaller
2016-08-04 15:01 ` Tony Lindgren
2016-08-04 20:59 ` Andreas Kemnade
2016-08-04 16:31 ` Andreas Kemnade
2016-08-04 16:44 ` Andreas Kemnade
2016-08-05 13:55 ` Tony Lindgren
2016-08-05 15:20 ` Andreas Kemnade
2016-08-06 6:21 ` Tony Lindgren
2016-08-09 5:35 ` Andreas Kemnade
2016-08-11 18:25 ` Tony Lindgren
2016-09-09 19:27 ` [v2] " Laurent Pinchart
2016-09-09 20:08 ` Tony Lindgren
2016-09-09 20:21 ` Laurent Pinchart
2016-09-09 20:40 ` Andreas Kemnade
2016-09-09 20:55 ` Tony Lindgren
2016-09-09 20:51 ` Tony Lindgren
2016-09-09 21:22 ` Andreas Kemnade
2016-09-09 21:33 ` Tony Lindgren [this message]
2016-09-09 23:40 ` Tony Lindgren
2016-09-10 11:27 ` Andreas Kemnade
2016-09-10 13:07 ` Tony Lindgren
2016-09-11 9:06 ` Laurent Pinchart
2016-09-12 14:35 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909213341.m2tmrvws5ffomnho@atomide.com \
--to=tony@atomide.com \
--cc=andreas@kemnade.info \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).