From: Tony Lindgren <tony@atomide.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Andreas Kemnade <andreas@kemnade.info>, Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [v2] musb: omap2430: do not assume balanced enable()/disable()
Date: Mon, 12 Sep 2016 07:35:55 -0700 [thread overview]
Message-ID: <20160912143554.bx33iibcebvqvlx3@atomide.com> (raw)
In-Reply-To: <1486773.OWvLIvzMHp@avalon>
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [160911 02:06]:
> Hi Tony,
>
> On Saturday 10 Sep 2016 06:07:50 Tony Lindgren wrote:
> > * Andreas Kemnade <andreas@kemnade.info> [160910 04:27]:
> > > On Fri, 9 Sep 2016 16:40:15 -0700 Tony Lindgren wrote:
> > >> * Tony Lindgren <tony@atomide.com> [160909 14:33]:
> > >>> * Andreas Kemnade <andreas@kemnade.info> [160909 14:22]:
> > >>>> We have two independant things:
> > >>>> 1. phy-twl4030-usb (and perhaps others) do not enable
> > >>>>
> > >>>> the phy enough to allow charging on pm_runtime_get().
> > >>>> That is fixed by my phy-related patches.
> > >>>
> > >>> OK
> > >>>
> > >>>> 2. phy_power_off/on() in called in an unbalanced way if
> > >>>> it is called behind musb_platform_enable()/disable()
> > >>>> as it happens in omap2430.c. Two ways to fix it:
> > >>>> a) prevent phy_power_off()/on() to be called in
> > >>>> an unbalanced way in omap240.c
> > >>>>
> > >>>> b) prevent musb_platform_enable()
> > >>>> musb_platform_disable() to be called in an
> > >>>> unbalanced way by fixing musb_core.c
> > >>>>
> > >>>> Fixing 1. is enough on gta04 to fix charging and hide 2. enough to
> > >>>> have gadget working for the most common usecases. (not using
> > >>>> twl4030-charger would not work yet)
> > >>>> But in the longer term 2. has to be fixed too.
> > >>>
> > >>> Sounds like option 2b here is the real fix.
> > >>
> > >> And doing full option 2b would be intrusive because of musb_stop
> > >> also calling musb_platform_disable. Here's a suggested fix for
> > >> v4.8-rc cycle.
> > >
> > > musb_platform_disable() in musb_stop() seems to be balanced.
> > >
> > > from my list in an earlier mail:
> > > musb_platform_disable() in musb_remove() called upon module removal
> > >
> > > To my analysis this is odd because musb_stop() is also called indirectly
> > > upon removal.
> > > But topic that can be left for later.
> >
> > OK will update the patch description. You probaby should attempt
> > to do a patch to make the calls paired as you already know what
> > needs to be done there..
> >
> > >> Seems to work for me for omap3 torpedo using phy-twl4030-usb,
> > >> omap4 pandaboard es using phy-twl6030-usb and am335x beaglebone
> > >> black using dsps glue. Also PM runtime works on omap3.
> > >>
> > >> This patch causes a slight merge conlict with Andrea's patches,
> > >> as listed in #1 above, but we should probably merge this first
> > >> as a fix. That is assuming it does not cause side effects to
> > >> Andrea's phy-twl4030-usb charger test case.
> > >
> > > Hmm, if the patch will gender-change me, then a clear NAK ;-)
> >
> > Sorry typo there, s/Andrea/Andreas/, no need for other radical
> > changes :)
> >
> > >> Can you guys please test? If things work I'll resend the
> > >> patch with proper tested-bys and acks.
> > >
> > > I tested the patch without any other musb/phy-fixes.
> > > No regressions. It fixes Gadget to be usable. Charging seems
> > > not to be totally stable. I will check my phy-patches
> > > on top of that again.
> > > PM runtime probably still desires some work on it.
> > > But I give a clear Ack for merging this one first.
> >
> > OK good to hear & thanks for testing. Let's see what Laurent
> > says.
>
> I say
>
> Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Thank you for the fix.
OK great, will send a proper patch with acks shortly.
Thanks,
Tony
prev parent reply other threads:[~2016-09-12 14:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 15:38 [PATCH v2] musb: omap2430: do not assume balanced enable()/disable() Andreas Kemnade
2016-08-03 17:07 ` [Letux-kernel] " H. Nikolaus Schaller
2016-08-04 14:29 ` Tony Lindgren
2016-08-04 14:49 ` H. Nikolaus Schaller
2016-08-04 15:01 ` Tony Lindgren
2016-08-04 20:59 ` Andreas Kemnade
2016-08-04 16:31 ` Andreas Kemnade
2016-08-04 16:44 ` Andreas Kemnade
2016-08-05 13:55 ` Tony Lindgren
2016-08-05 15:20 ` Andreas Kemnade
2016-08-06 6:21 ` Tony Lindgren
2016-08-09 5:35 ` Andreas Kemnade
2016-08-11 18:25 ` Tony Lindgren
2016-09-09 19:27 ` [v2] " Laurent Pinchart
2016-09-09 20:08 ` Tony Lindgren
2016-09-09 20:21 ` Laurent Pinchart
2016-09-09 20:40 ` Andreas Kemnade
2016-09-09 20:55 ` Tony Lindgren
2016-09-09 20:51 ` Tony Lindgren
2016-09-09 21:22 ` Andreas Kemnade
2016-09-09 21:33 ` Tony Lindgren
2016-09-09 23:40 ` Tony Lindgren
2016-09-10 11:27 ` Andreas Kemnade
2016-09-10 13:07 ` Tony Lindgren
2016-09-11 9:06 ` Laurent Pinchart
2016-09-12 14:35 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912143554.bx33iibcebvqvlx3@atomide.com \
--to=tony@atomide.com \
--cc=andreas@kemnade.info \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).