From: Lee Jones <lee.jones@linaro.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Keerthy <j-keerthy@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x
Date: Tue, 13 Sep 2016 13:42:15 +0100 [thread overview]
Message-ID: <20160913124215.GC28894@dell> (raw)
In-Reply-To: <1473123595-30475-1-git-send-email-axel.lin@ingics.com>
On Tue, 06 Sep 2016, Axel Lin wrote:
> The mutex is not used, so remove it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/lp873x.c | 2 --
> include/linux/mfd/lp873x.h | 1 -
> 2 files changed, 3 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/lp873x.c b/drivers/mfd/lp873x.c
> index 9af064c..873c608 100644
> --- a/drivers/mfd/lp873x.c
> +++ b/drivers/mfd/lp873x.c
> @@ -53,8 +53,6 @@ static int lp873x_probe(struct i2c_client *client,
> return ret;
> }
>
> - mutex_init(&lp873->lock);
> -
> ret = regmap_read(lp873->regmap, LP873X_REG_OTP_REV, &otpid);
> if (ret) {
> dev_err(lp873->dev, "Failed to read OTP ID\n");
> diff --git a/include/linux/mfd/lp873x.h b/include/linux/mfd/lp873x.h
> index 83b1bd7..edbec83 100644
> --- a/include/linux/mfd/lp873x.h
> +++ b/include/linux/mfd/lp873x.h
> @@ -263,7 +263,6 @@ enum lp873x_regulator_id {
> struct lp873x {
> struct device *dev;
> u8 rev;
> - struct mutex lock; /* lock guarding the data structure */
> struct regmap *regmap;
> };
> #endif /* __LINUX_MFD_LP873X_H */
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-09-13 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 0:59 [PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x Axel Lin
2016-09-13 12:42 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913124215.GC28894@dell \
--to=lee.jones@linaro.org \
--cc=axel.lin@ingics.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).