* [PATCH] dmaengine: omap-dma: Correct type2 descriptor's member types
@ 2016-09-13 7:58 Peter Ujfalusi
2016-09-14 13:32 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2016-09-13 7:58 UTC (permalink / raw)
To: vinod.koul, dan.j.williams, linux; +Cc: dmaengine, linux-kernel, linux-omap
The type of CDEI, CSEI, CDFI and CSFI is signed.
This did not caused issue so far as we only use unsigned values.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/dma/omap-dma.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
index aef52011d7c0..1b7f5f32bf74 100644
--- a/drivers/dma/omap-dma.c
+++ b/drivers/dma/omap-dma.c
@@ -71,10 +71,10 @@ struct omap_type2_desc {
uint32_t addr; /* src or dst */
uint16_t fn;
uint16_t cicr;
- uint16_t cdei;
- uint16_t csei;
- uint32_t cdfi;
- uint32_t csfi;
+ int16_t cdei;
+ int16_t csei;
+ int32_t cdfi;
+ int32_t csfi;
} __packed;
struct omap_sg {
--
2.10.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: omap-dma: Correct type2 descriptor's member types
2016-09-13 7:58 [PATCH] dmaengine: omap-dma: Correct type2 descriptor's member types Peter Ujfalusi
@ 2016-09-14 13:32 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2016-09-14 13:32 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: dan.j.williams, linux, dmaengine, linux-kernel, linux-omap
On Tue, Sep 13, 2016 at 10:58:43AM +0300, Peter Ujfalusi wrote:
> The type of CDEI, CSEI, CDFI and CSFI is signed.
> This did not caused issue so far as we only use unsigned values.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-14 13:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-13 7:58 [PATCH] dmaengine: omap-dma: Correct type2 descriptor's member types Peter Ujfalusi
2016-09-14 13:32 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).