From: Rob Herring <robh@kernel.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
khilman@baylibre.com, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, broonie@kernel.org, carlo@caione.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible
Date: Fri, 16 Sep 2016 10:28:38 -0500 [thread overview]
Message-ID: <20160916152838.GA6795@rob-hp-laptop> (raw)
In-Reply-To: <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2@suse.de>
On Thu, Sep 08, 2016 at 02:50:37PM +0200, Andreas Färber wrote:
> Am 08.09.2016 um 14:04 schrieb Andreas Färber:
> > Am 08.09.2016 um 09:53 schrieb Neil Armstrong:
> >> This patchset adds a specific compatible string in the Meson SPIFC driver for
> >> the Amlogic Meson GXBB SoC.
> >
> > Any particular reason? We could just reuse the meson6 one since there
> > appear to be no code changes so far.
>
> So Neil is essentially telling me they don't know whether there are any
> differences in the IP block, so a separate compatible string was chosen.
>
> No objection from my side, but a general clarification from device tree
> maintainers when and when not to would be appreciated. (+ devicetree)
New chip, always define a new compatible. If you think they are the same
or are close enough to function with the existing driver, then put both
compatible strings in the DT.
Rob
next prev parent reply other threads:[~2016-09-16 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 7:53 [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible Neil Armstrong
2016-09-08 7:53 ` [PATCH 1/2] dt-bindings: spi-meson: Add GXBB Compatible string Neil Armstrong
2016-09-12 19:07 ` Mark Brown
2016-09-16 15:33 ` Rob Herring
2016-09-08 7:53 ` [PATCH 2/2] spi: meson: Add GXBB compatible Neil Armstrong
2016-09-08 12:04 ` [PATCH 0/2] spi: meson: Add Amlogic " Andreas Färber
2016-09-08 12:50 ` Andreas Färber
2016-09-08 13:21 ` Ben Dooks
2016-09-08 18:17 ` Kevin Hilman
2016-09-16 15:28 ` Rob Herring [this message]
2016-09-08 18:13 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916152838.GA6795@rob-hp-laptop \
--to=robh@kernel.org \
--cc=afaerber@suse.de \
--cc=broonie@kernel.org \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).