* [PATCH] sysfs print name of undiscoverable attribute group as well
@ 2016-09-15 19:44 Johannes Thumshirn
2016-09-18 7:36 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Johannes Thumshirn @ 2016-09-15 19:44 UTC (permalink / raw)
To: Greg KH; +Cc: Linux Kernel Mailinglist, Johannes Thumshirn
Print the name of an undiscoverable attribute group as well, not just
the pointer's address.
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
fs/sysfs/group.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c
index dc1358b..b1a3557 100644
--- a/fs/sysfs/group.c
+++ b/fs/sysfs/group.c
@@ -233,8 +233,8 @@ void sysfs_remove_group(struct kobject *kobj,
kn = kernfs_find_and_get(parent, grp->name);
if (!kn) {
WARN(!kn, KERN_WARNING
- "sysfs group %p not found for kobject '%s'\n",
- grp, kobject_name(kobj));
+ "sysfs group '%s' %p not found for kobject '%s'\n",
+ grp->name, grp, kobject_name(kobj));
return;
}
} else {
--
1.8.5.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sysfs print name of undiscoverable attribute group as well
2016-09-15 19:44 [PATCH] sysfs print name of undiscoverable attribute group as well Johannes Thumshirn
@ 2016-09-18 7:36 ` Greg KH
2016-09-18 17:57 ` Johannes Thumshirn
2016-09-19 8:07 ` Johannes Thumshirn
0 siblings, 2 replies; 4+ messages in thread
From: Greg KH @ 2016-09-18 7:36 UTC (permalink / raw)
To: Johannes Thumshirn; +Cc: Linux Kernel Mailinglist
On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote:
> Print the name of an undiscoverable attribute group as well, not just
> the pointer's address.
Shouldn't we just drop the pointer address and use the name? It's bad
form to be printing kernel addresses to the syslog these days given that
it is a security information leak :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sysfs print name of undiscoverable attribute group as well
2016-09-18 7:36 ` Greg KH
@ 2016-09-18 17:57 ` Johannes Thumshirn
2016-09-19 8:07 ` Johannes Thumshirn
1 sibling, 0 replies; 4+ messages in thread
From: Johannes Thumshirn @ 2016-09-18 17:57 UTC (permalink / raw)
To: Greg KH; +Cc: Linux Kernel Mailinglist
On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote:
> On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote:
> > Print the name of an undiscoverable attribute group as well, not just
> > the pointer's address.
>
> Shouldn't we just drop the pointer address and use the name? It's bad
> form to be printing kernel addresses to the syslog these days given that
> it is a security information leak :(
Probably yes. Given it's not etremely helpful when debugging either
I'll send a v2 with the address dropped.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sysfs print name of undiscoverable attribute group as well
2016-09-18 7:36 ` Greg KH
2016-09-18 17:57 ` Johannes Thumshirn
@ 2016-09-19 8:07 ` Johannes Thumshirn
1 sibling, 0 replies; 4+ messages in thread
From: Johannes Thumshirn @ 2016-09-19 8:07 UTC (permalink / raw)
To: Greg KH; +Cc: Linux Kernel Mailinglist
On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote:
> On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote:
> > Print the name of an undiscoverable attribute group as well, not just
> > the pointer's address.
>
> Shouldn't we just drop the pointer address and use the name? It's bad
> form to be printing kernel addresses to the syslog these days given that
> it is a security information leak :(
Yes probably and it isn't that much of a help when debugging
either. I'll resend a v2.
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-19 8:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-15 19:44 [PATCH] sysfs print name of undiscoverable attribute group as well Johannes Thumshirn
2016-09-18 7:36 ` Greg KH
2016-09-18 17:57 ` Johannes Thumshirn
2016-09-19 8:07 ` Johannes Thumshirn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).