[PATCH 01/11 V2] staging: dgnc: remove redundant initialization for channel array

[PATCH 01/11 V2] staging: dgnc: remove redundant initialization for channel array

[Daeseok Youn]

The channel array in board_t was initialized in dgnc_found_board()
with NULL. But the channel is going to initialize in dgnc_tty_init()
again. So the channel array doesn't need to set NULL
for initailization in dgnc_found_board().

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
V2: The subject line was cut off, I put it completely and update
change log.

 drivers/staging/dgnc/dgnc_driver.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
index 01e948c..b598034 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -400,9 +400,6 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
 
 	brd->state		= BOARD_FOUND;
 
-	for (i = 0; i < MAXPORTS; i++)
-		brd->channels[i] = NULL;
-
 	/* store which card & revision we have */
 	pci_read_config_word(pdev, PCI_SUBSYSTEM_VENDOR_ID, &brd->subvendor);
 	pci_read_config_word(pdev, PCI_SUBSYSTEM_ID, &brd->subdevice);
-- 
1.9.1

Re: [PATCH 01/11 V2] staging: dgnc: remove redundant initialization for channel array

[Greg KH]

On Fri, Sep 23, 2016 at 10:25:02AM +0900, Daeseok Youn wrote:
> The channel array in board_t was initialized in dgnc_found_board()
> with NULL. But the channel is going to initialize in dgnc_tty_init()
> again. So the channel array doesn't need to set NULL
> for initailization in dgnc_found_board().
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> V2: The subject line was cut off, I put it completely and update
> change log.

I only got 6 patches of an 11 patch series here, what happened?

Please resend the whole series.

thanks,

greg k-h

Re: [PATCH 01/11 V2] staging: dgnc: remove redundant initialization for channel array

[DaeSeok Youn]

2016-09-23 21:15 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>:
> On Fri, Sep 23, 2016 at 10:25:02AM +0900, Daeseok Youn wrote:
>> The channel array in board_t was initialized in dgnc_found_board()
>> with NULL. But the channel is going to initialize in dgnc_tty_init()
>> again. So the channel array doesn't need to set NULL
>> for initailization in dgnc_found_board().
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>> ---
>> V2: The subject line was cut off, I put it completely and update
>> change log.
>
> I only got 6 patches of an 11 patch series here, what happened?
I sent only updated 6 patches of series, I will resend 11 patches again.

Thanks.
Regards,
Daeseok Youn.
>
> Please resend the whole series.
>
> thanks,
>
> greg k-h