From: Peter Zijlstra <peterz@infradead.org>
To: Babu Moger <babu.moger@oracle.com>
Cc: mingo@redhat.com, akpm@linux-foundation.org,
keescook@chromium.org, dan.j.williams@intel.com,
aryabinin@virtuozzo.com, tj@kernel.org, sam@ravnborg.org,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH v3 1/2] config: Adding the new config parameter CONFIG_PROVE_LOCKING_SMALL for sparc
Date: Wed, 28 Sep 2016 10:39:26 +0200 [thread overview]
Message-ID: <20160928083926.GQ5016@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1475004808-91920-2-git-send-email-babu.moger@oracle.com>
On Tue, Sep 27, 2016 at 12:33:27PM -0700, Babu Moger wrote:
> This new config parameter limits the space used for "Lock debugging:
> prove locking correctness" by about 4MB. The current sparc systems have
> the limitation of 32MB size for kernel size including .text, .data and
> .bss sections. With PROVE_LOCKING feature, the kernel size could grow
> beyond this limit and causing system boot-up issues. With this option,
> kernel limits the size of the entries of lock_chains, stack_trace etc.,
> so that kernel fits in required size limit. This is not visible to user
> and only used for sparc.
>
> Signed-off-by: Babu Moger <babu.moger@oracle.com>
You forgot to Cc Dave, and since you're touching sparc I need an Ack
from him before I can queue this.
Dave?
> ---
> arch/sparc/Kconfig | 1 +
> lib/Kconfig.debug | 3 +++
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
> index 59b0960..8da321c 100644
> --- a/arch/sparc/Kconfig
> +++ b/arch/sparc/Kconfig
> @@ -44,6 +44,7 @@ config SPARC
> select ARCH_HAS_SG_CHAIN
> select CPU_NO_EFFICIENT_FFS
> select HAVE_ARCH_HARDENED_USERCOPY
> + select PROVE_LOCKING_SMALL if PROVE_LOCKING
>
> config SPARC32
> def_bool !64BIT
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index cab7405..597e589 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1084,6 +1084,9 @@ config PROVE_LOCKING
>
> For more details, see Documentation/locking/lockdep-design.txt.
>
> +config PROVE_LOCKING_SMALL
> + bool
> +
> config LOCKDEP
> bool
> depends on DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT
> --
> 1.7.1
>
next prev parent reply other threads:[~2016-09-28 8:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 19:33 [PATCH v3 0/2] Ajust lockdep static allocations for sparc Babu Moger
2016-09-27 19:33 ` [PATCH v3 1/2] config: Adding the new config parameter CONFIG_PROVE_LOCKING_SMALL " Babu Moger
2016-09-28 8:39 ` Peter Zijlstra [this message]
2016-09-29 13:53 ` Babu Moger
2016-09-30 5:19 ` David Miller
2016-10-05 22:56 ` Babu Moger
2016-10-06 4:27 ` Sam Ravnborg
2016-09-28 20:51 ` Sam Ravnborg
2016-09-27 19:33 ` [PATCH v3 2/2] lockdep: Limit static allocations if PROVE_LOCKING_SMALL is defined Babu Moger
2016-09-28 20:51 ` Sam Ravnborg
2016-09-29 13:55 ` Babu Moger
2016-11-18 19:34 ` [PATCH v3 0/2] Ajust lockdep static allocations for sparc David Miller
2016-11-19 11:53 ` Peter Zijlstra
2016-11-21 7:17 ` Ingo Molnar
2016-11-29 11:14 ` Geert Uytterhoeven
2016-11-29 11:41 ` Peter Zijlstra
2016-11-29 11:52 ` Geert Uytterhoeven
2016-11-29 12:29 ` Peter Zijlstra
2016-11-29 12:35 ` Peter Zijlstra
2016-11-29 13:26 ` Geert Uytterhoeven
2016-11-29 13:31 ` Peter Zijlstra
2016-11-29 13:39 ` Geert Uytterhoeven
2016-11-29 13:50 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928083926.GQ5016@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=babu.moger@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).